From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: Re: cpufreq/linux/arch/arm/mach-sa1100 cpu-sa1100.c, 1.5, 1.6 cpu-sa1110.c, 1.12, 1.13 Date: Thu, 26 Aug 2004 15:15:40 +0100 Sender: cpufreq-bounces@www.linux.org.uk Message-ID: <20040826151540.F21364@flint.arm.linux.org.uk> References: <20040826151034.E21364@flint.arm.linux.org.uk> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20040826151034.E21364@flint.arm.linux.org.uk>; from rmk@arm.linux.org.uk on Thu, Aug 26, 2004 at 03:10:34PM +0100 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cpufreq-bounces+glkc-cpufreq=gmane.org@www.linux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cpufreq@www.linux.org.uk On Thu, Aug 26, 2004 at 03:10:34PM +0100, Russell King wrote: > On Thu, Aug 26, 2004 at 02:25:51PM +0100, Ducrot Bruno wrote: > > Update of /mnt/src/cvsroot/cpufreq/linux/arch/arm/mach-sa1100 > > In directory flint:/tmp/cvs-serv26017/linux/arch/arm/mach-sa1100 > > @@ -329,8 +329,12 @@ > > } > > > > static struct cpufreq_driver sa1110_driver = { > > + .flags = CPUFREQ_STICKY | > > > + CPUFREQ_PANIC_OUTOFSYNC | <<<< > > + CPUFREQ_PANIC_RESUME_OUTOFSYNC, <<<< > > Erm, _why_ ? > > This makes very little sense. If you put the system to sleep at > 147MHz and it normally boots at 206.4MHz, you'll resume at 206.4MHz. > > It's up to the kernel to reset the clock rate itself. This is nothing > new - cpufreq has always done this, so why are we adding this new > restriction? > > It makes zero sense. And to follow that up, yes, I missed it back in June when I added the CPUFREQ_STICKY here. However, I was completely unaware that this change had been made back in May 2004. Can we please route changes to architecture files via the architecture people _before_ merging them. Pretty please? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core