From: "David S. Miller" <davem@redhat.com>
To: linux-arch@vger.kernel.org
Subject: bug in syscal arg sign extension
Date: Thu, 26 Aug 2004 18:08:02 -0700 [thread overview]
Message-ID: <20040826180802.4f1e6dbb.davem@redhat.com> (raw)
Remember this topic long ago?
Anyways, there was a bug in my sparc64 code and it causes all
kinds of trouble for logging daemons. I was sign extending
the buffer pointer arg instead of the length arg to sys_syslog()
Ooops!
:-)
Fix attached in cases anyone was doing work for the platform
based upon my sparc64 stuff.
===== arch/sparc64/kernel/sys32.S 1.9 vs edited =====
--- 1.9/arch/sparc64/kernel/sys32.S 2004-06-03 14:51:21 -07:00
+++ edited/arch/sparc64/kernel/sys32.S 2004-08-26 17:49:39 -07:00
@@ -120,7 +120,7 @@
SIGN2(sys32_setpgid, sys_setpgid, %o0, %o1)
SIGN3(sys32_setpriority, sys_setpriority, %o0, %o1, %o2)
SIGN1(sys32_ssetmask, sys_ssetmask, %o0)
-SIGN2(sys32_syslog, sys_syslog, %o0, %o1)
+SIGN2(sys32_syslog, sys_syslog, %o0, %o2)
SIGN1(sys32_umask, sys_umask, %o0)
SIGN3(sys32_tgkill, sys_tgkill, %o0, %o1, %o2)
SIGN1(sys32_sendto, sys_sendto, %o0)
next reply other threads:[~2004-08-27 1:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-27 1:08 David S. Miller [this message]
2004-08-27 15:52 ` bug in syscal arg sign extension Andi Kleen
2004-08-27 19:27 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040826180802.4f1e6dbb.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.