From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org, gregkh@us.ibm.com
Subject: Re: [2.4 patch][1/6] ibmphp_res.c: fix gcc 3.4 compilation
Date: Thu, 26 Aug 2004 21:54:55 +0200 [thread overview]
Message-ID: <20040826195455.GC12772@fs.tum.de> (raw)
In-Reply-To: <20040826195133.GB12772@fs.tum.de>
I got the following compile error when trying to build 2.4.28-pre2 using
gcc 3.4:
<-- snip -->
...
gcc-3.4 -D__KERNEL__
-I/home/bunk/linux/kernel-2.4/linux-2.4.28-pre2-full/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon
-fno-unit-at-a-time -D_LINUX
-I/home/bunk/linux/kernel-2.4/linux-2.4.28-pre2-full/drivers/acpi
-nostdinc -iwithprefix include -DKBUILD_BASENAME=ibmphp_res -c -o
ibmphp_res.o ibmphp_res.c
ibmphp_res.c: In function `ibmphp_rsrc_init':
ibmphp_res.c:45: sorry, unimplemented: inlining failed in call to
'find_bus_wprev': function body not available
ibmphp_res.c:237: sorry, unimplemented: called from here
ibmphp_res.c:45: sorry, unimplemented: inlining failed in call to
'find_bus_wprev': function body not available
ibmphp_res.c:261: sorry, unimplemented: called from here
ibmphp_res.c:45: sorry, unimplemented: inlining failed in call to
'find_bus_wprev': function body not available
ibmphp_res.c:284: sorry, unimplemented: called from here
make[3]: *** [ibmphp_res.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.28-pre2-full/drivers/hotplug'
<-- snip -->
The patch below fixes this issue by uninlining find_bus_wprev (as done
in 2.6).
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
--- linux-2.4.28-pre2-full/drivers/hotplug/ibmphp_res.c.old 2004-08-26 17:09:38.000000000 +0200
+++ linux-2.4.28-pre2-full/drivers/hotplug/ibmphp_res.c 2004-08-26 17:10:16.000000000 +0200
@@ -42,7 +42,7 @@
static int update_bridge_ranges (struct bus_node **);
static int add_range (int type, struct range_node *, struct bus_node *);
static void fix_resources (struct bus_node *);
-static inline struct bus_node *find_bus_wprev (u8, struct bus_node **, u8);
+static struct bus_node *find_bus_wprev (u8, struct bus_node **, u8);
static LIST_HEAD(gbuses);
LIST_HEAD(ibmphp_res_head);
@@ -1757,7 +1757,7 @@
return find_bus_wprev (bus_number, NULL, 0);
}
-static inline struct bus_node *find_bus_wprev (u8 bus_number, struct bus_node **prev, u8 flag)
+static struct bus_node *find_bus_wprev (u8 bus_number, struct bus_node **prev, u8 flag)
{
struct bus_node *bus_cur;
struct list_head *tmp;
next prev parent reply other threads:[~2004-08-26 20:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-26 19:51 [2.4 patch][0/6] fix compile errors with gcc 3.4 Adrian Bunk
2004-08-26 19:54 ` Adrian Bunk [this message]
2004-08-27 12:03 ` [2.4 patch][1/6] ibmphp_res.c: fix gcc 3.4 compilation Marcelo Tosatti
2004-08-27 14:54 ` Adrian Bunk
2004-08-26 19:56 ` [2.4 patch][1/6] lmc_media.c: " Adrian Bunk
2004-08-28 22:58 ` Jeff Garzik
2004-08-28 23:13 ` Adrian Bunk
2004-08-26 19:59 ` [2.4 patch][3/6] ircomm_param.c: fix __FUNCTION__ paste error Adrian Bunk
2004-08-26 20:02 ` [2.4 patch][4/6] irlmp.c: fix gcc 3.4 compilation Adrian Bunk
2004-08-26 20:04 ` [2.4 patch][5/6] asm-i386/smpboot.h: " Adrian Bunk
2004-08-26 20:07 ` [2.4 patch][6/6] dscc4.c: " Adrian Bunk
2004-08-27 18:52 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040826195455.GC12772@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=gregkh@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.