From: "David S. Miller" <davem@redhat.com>
To: Dave Airlie <airlied@linux.ie>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org, arjanv@redhat.com
Subject: Re: drm fixup 2/2 - optimise i8x0 accesses..
Date: Fri, 27 Aug 2004 13:04:15 -0700 [thread overview]
Message-ID: <20040827130415.754d4451.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0408271512330.32411@skynet>
On Fri, 27 Aug 2004 15:13:54 +0100 (IST)
Dave Airlie <airlied@linux.ie> wrote:
> the patch below optimises the drm code to not do put_user() on memory the
> kernel allocated and then mmap-installed to userspace, but instead makes it
> use the kernel virtual address directly instead.
This might cause major problems on systems with virtually indexed
caches if precautions are not made at buffer allocation time such
that the virtual cache color of the kernel mapping is the same
as the user mapping.
Arjan, you should know better :-)
I also don't understand what this "optimization" is? You don't need
a verify_area, therefore you can use __put_user() which amounts to
a load/store and an integer move instruction.
next prev parent reply other threads:[~2004-08-27 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-27 14:13 drm fixup 2/2 - optimise i8x0 accesses Dave Airlie
2004-08-27 20:04 ` David S. Miller [this message]
2004-08-27 20:08 ` Arjan van de Ven
2004-08-27 20:17 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040827130415.754d4451.davem@redhat.com \
--to=davem@redhat.com \
--cc=airlied@linux.ie \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.