From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Date: Fri, 27 Aug 2004 23:36:02 +0000 Subject: Re: page fault scalability patch final : i386 tested, x86_64 support added Message-Id: <20040827233602.GB1024@wotan.suse.de> List-Id: References: <20040815165827.0c0c8844.davem@redhat.com> <20040815185644.24ecb247.davem@redhat.com> <20040816143903.GY11200@holomorphy.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Lameter Cc: akpm@osdl.org, William Lee Irwin III , "David S. Miller" , raybry@sgi.com, ak@muc.de, benh@kernel.crashing.org, manfred@colorfullife.com, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, vrajesh@umich.edu, hugh@veritas.com > Index: linux-2.6.9-rc1/include/linux/sched.h > =================================> --- linux-2.6.9-rc1.orig/include/linux/sched.h 2004-08-25 10:50:12.534021000 -0700 > +++ linux-2.6.9-rc1/include/linux/sched.h 2004-08-27 12:14:09.564008624 -0700 > @@ -197,9 +197,10 @@ > pgd_t * pgd; > atomic_t mm_users; /* How many users with user space? */ > atomic_t mm_count; /* How many references to "struct mm_struct" (users count as 1) */ > + atomic_t mm_rss; /* Number of pages used by this mm struct */ atomic_t is normally 32bit, even on a 64bit arch. This will limit the max memory size per process to 2^(32+PAGE_SHIFT). I don't think that's a good idea. On some architectures it used to be 24bit only even, but I think that has been fixed. I think you need atomic64_t -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267310AbUH0Xjm (ORCPT ); Fri, 27 Aug 2004 19:39:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267350AbUH0Xjh (ORCPT ); Fri, 27 Aug 2004 19:39:37 -0400 Received: from cantor.suse.de ([195.135.220.2]:34182 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S267310AbUH0Xja (ORCPT ); Fri, 27 Aug 2004 19:39:30 -0400 Date: Sat, 28 Aug 2004 01:36:02 +0200 From: Andi Kleen To: Christoph Lameter Cc: akpm@osdl.org, William Lee Irwin III , "David S. Miller" , raybry@sgi.com, ak@muc.de, benh@kernel.crashing.org, manfred@colorfullife.com, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, vrajesh@umich.edu, hugh@veritas.com Subject: Re: page fault scalability patch final : i386 tested, x86_64 support added Message-ID: <20040827233602.GB1024@wotan.suse.de> References: <20040815165827.0c0c8844.davem@redhat.com> <20040815185644.24ecb247.davem@redhat.com> <20040816143903.GY11200@holomorphy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > Index: linux-2.6.9-rc1/include/linux/sched.h > =================================================================== > --- linux-2.6.9-rc1.orig/include/linux/sched.h 2004-08-25 10:50:12.534021000 -0700 > +++ linux-2.6.9-rc1/include/linux/sched.h 2004-08-27 12:14:09.564008624 -0700 > @@ -197,9 +197,10 @@ > pgd_t * pgd; > atomic_t mm_users; /* How many users with user space? */ > atomic_t mm_count; /* How many references to "struct mm_struct" (users count as 1) */ > + atomic_t mm_rss; /* Number of pages used by this mm struct */ atomic_t is normally 32bit, even on a 64bit arch. This will limit the max memory size per process to 2^(32+PAGE_SHIFT). I don't think that's a good idea. On some architectures it used to be 24bit only even, but I think that has been fixed. I think you need atomic64_t -Andi