All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andries Brouwer <Andries.Brouwer@cwi.nl>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andries.Brouwer@cwi.nl, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] remove unused ext2_panic
Date: Sat, 28 Aug 2004 03:19:59 +0200	[thread overview]
Message-ID: <20040828011959.GC16444@apps.cwi.nl> (raw)
In-Reply-To: <Pine.LNX.4.58.0408271104300.14196@ppc970.osdl.org>

On Fri, Aug 27, 2004 at 11:04:59AM -0700, Linus Torvalds wrote:

> Fixed (slightly differently) in current -BK.

Don't see it yet. Something else: ext2_panic is unused, it seems.

Andries

diff -uprN -X /linux/dontdiff a/fs/ext2/ext2.h b/fs/ext2/ext2.h
--- a/fs/ext2/ext2.h	2003-12-18 03:59:56.000000000 +0100
+++ b/fs/ext2/ext2.h	2004-08-28 03:19:30.000000000 +0200
@@ -131,9 +131,6 @@ extern int ext2_ioctl (struct inode *, s
 /* super.c */
 extern void ext2_error (struct super_block *, const char *, const char *, ...)
 	__attribute__ ((format (printf, 3, 4)));
-extern NORET_TYPE void ext2_panic (struct super_block *, const char *,
-				   const char *, ...)
-	__attribute__ ((NORET_AND format (printf, 3, 4)));
 extern void ext2_warning (struct super_block *, const char *, const char *, ...)
 	__attribute__ ((format (printf, 3, 4)));
 extern void ext2_update_dynamic_rev (struct super_block *sb);
diff -uprN -X /linux/dontdiff a/fs/ext2/super.c b/fs/ext2/super.c
--- a/fs/ext2/super.c	2004-05-28 20:53:22.000000000 +0200
+++ b/fs/ext2/super.c	2004-08-28 03:20:00.000000000 +0200
@@ -66,27 +66,6 @@ void ext2_error (struct super_block * sb
 	}
 }
 
-NORET_TYPE void ext2_panic (struct super_block * sb, const char * function,
-			    const char * fmt, ...)
-{
-	va_list args;
-	struct ext2_sb_info *sbi = EXT2_SB(sb);
-
-	if (!(sb->s_flags & MS_RDONLY)) {
-		sbi->s_mount_state |= EXT2_ERROR_FS;
-		sbi->s_es->s_state =
-			cpu_to_le16(le16_to_cpu(sbi->s_es->s_state) | EXT2_ERROR_FS);
-		mark_buffer_dirty(sbi->s_sbh);
-		sb->s_dirt = 1;
-	}
-	va_start (args, fmt);
-	vsprintf (error_buf, fmt, args);
-	va_end (args);
-	sb->s_flags |= MS_RDONLY;
-	panic ("EXT2-fs panic (device %s): %s: %s\n",
-	       sb->s_id, function, error_buf);
-}
-
 void ext2_warning (struct super_block * sb, const char * function,
 		   const char * fmt, ...)
 {

  reply	other threads:[~2004-08-28  1:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-27 16:06 [PATCH] reiserfs/xattr fix Andries.Brouwer
2004-08-27 18:04 ` Linus Torvalds
2004-08-28  1:19   ` Andries Brouwer [this message]
2004-08-28  1:58     ` [PATCH] remove unused ext2_panic Linus Torvalds
2004-08-28 21:30       ` [PATCH] ext2 mount options doc Andries Brouwer
2004-08-28 21:46         ` Andrew Morton
2004-08-28 22:08           ` Andries Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040828011959.GC16444@apps.cwi.nl \
    --to=andries.brouwer@cwi.nl \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.