From: Jeremy Higdon <jeremy@sgi.com>
To: Douglas Gilbert <dougg@torque.net>
Cc: linux-scsi@vger.kernel.org, james.bottomley@steeleye.com
Subject: Re: [PATCH] sg.c to set direction more reliably (was Re: [PATCH] fusion update to current APIs)
Date: Sat, 28 Aug 2004 02:39:45 -0700 [thread overview]
Message-ID: <20040828093945.GB137773@sgi.com> (raw)
In-Reply-To: <41301339.1020108@torque.net>
On Sat, Aug 28, 2004 at 03:08:09PM +1000, Douglas Gilbert wrote:
> Jeremy Higdon wrote:
> >On Thu, Aug 26, 2004 at 06:12:53PM -0700, Jeremy Higdon wrote:
> >
> >
> >This is one of those days when I seem to be working against myself.
> >It turns out that our RAID vendor modified their agent to trim
> >the "reply_len" field for write commands, but did not trim the
> >"count" field for read commands. So in this case, sg actually
> >guesses correctly when it needs to, and the app works. Only with
> >this patch, /var/log/messages gets filled with this new error
> >message.
> >
> >Doug, what do you think is the right thing to do?
>
> Jeremy,
> You could use a (block scope) static and only print out
> the warning the first time it is detected.
>
> Doug Gilbert
Yes, that's a good idea -- I'll add a rate limiter and also print
out the process name like James does in his recent deprecated
ioctl warning patch. I'll send a new patch out later this weekend.
Sorry for the churn.
thanks
jeremy
next prev parent reply other threads:[~2004-08-28 9:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-31 11:52 [PATCH] fusion update to current APIs Christoph Hellwig
2004-06-12 0:36 ` Jeremy Higdon
2004-06-12 3:45 ` Matthew Wilcox
2004-06-12 5:13 ` Jeremy Higdon
2004-06-12 5:20 ` Matthew Wilcox
2004-06-15 6:08 ` [PATCH] sg.c to set direction more reliably (was Re: [PATCH] fusion update to current APIs) Jeremy Higdon
2004-06-15 6:47 ` Douglas Gilbert
2004-06-15 7:41 ` Jeremy Higdon
2004-06-15 15:07 ` Jeff Garzik
2004-06-15 21:34 ` Jeremy Higdon
2004-06-15 22:10 ` Jeff Garzik
2004-06-15 22:15 ` Jeremy Higdon
2004-08-26 7:09 ` Jeremy Higdon
2004-08-26 8:44 ` Douglas Gilbert
2004-08-27 1:12 ` Jeremy Higdon
2004-08-27 8:10 ` Jeremy Higdon
2004-08-28 5:08 ` Douglas Gilbert
2004-08-28 9:39 ` Jeremy Higdon [this message]
2004-08-30 7:08 ` [PATCH] sg.c to warn about ambiguous data direction Jeremy Higdon
2004-06-15 6:54 ` [PATCH] sg.c to set direction more reliably (was Re: [PATCH] fusion update to current APIs) Jeff Garzik
2004-06-15 7:50 ` Jeremy Higdon
2004-06-15 7:57 ` Arjan van de Ven
2004-06-15 8:40 ` Jeremy Higdon
2004-06-15 8:17 ` Christoph Hellwig
2004-06-15 8:48 ` Jeremy Higdon
2004-06-15 9:10 ` Jeremy Higdon
2004-06-15 9:31 ` Jeremy Higdon
2004-06-15 17:42 ` Patrick Mansfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040828093945.GB137773@sgi.com \
--to=jeremy@sgi.com \
--cc=dougg@torque.net \
--cc=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.