From: William Lee Irwin III <wli@holomorphy.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2/5] consolidate bit waiting code patterns
Date: Sat, 28 Aug 2004 15:33:32 -0700 [thread overview]
Message-ID: <20040828223332.GA5492@holomorphy.com> (raw)
In-Reply-To: <20040828152904.4721522c.akpm@osdl.org>
William Lee Irwin III <wli@holomorphy.com> wrote:
>> +void fastcall __wake_up_bit(wait_queue_head_t *wq, void *word, int bit)
>> +{
>> + struct wait_bit_key key = __WAIT_BIT_KEY_INITIALIZER(word, bit);
>> + if (waitqueue_active(wq))
>> + __wake_up(wq, TASK_INTERRUPTIBLE|TASK_UNINTERRUPTIBLE, 1, &key);
>> +}
On Sat, Aug 28, 2004 at 03:29:04PM -0700, Andrew Morton wrote:
> The waitqueue_active() test needs a preceding barrier. Did it
> come from somewhere else, implicitly?
Yes, it comes from clearing the bit prior to calling this for wakeup.
-- wli
prev parent reply other threads:[~2004-08-28 22:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-28 20:05 [0/5] standardized waitqueue hashing William Lee Irwin III
2004-08-28 20:06 ` [1/5] move waitqueue functions to kernel/wait.c William Lee Irwin III
2004-08-28 20:08 ` [2/5] consolidate bit waiting code patterns William Lee Irwin III
2004-08-28 20:09 ` [3/5] " William Lee Irwin III
2004-08-28 20:11 ` [4/5] eliminate bh waitqueue hashtable William Lee Irwin III
2004-08-28 20:12 ` [5/5] eliminate inode " William Lee Irwin III
2004-08-28 22:37 ` [4/5] eliminate bh " Andrew Morton
2004-08-28 23:09 ` William Lee Irwin III
2004-08-28 20:21 ` [2/5] consolidate bit waiting code patterns William Lee Irwin III
2004-08-28 22:29 ` Andrew Morton
2004-08-28 22:33 ` William Lee Irwin III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040828223332.GA5492@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.