From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.33)
	id 1C1jOe-0000MS-7r
	for mharc-grub-devel@gnu.org; Mon, 30 Aug 2004 06:28:20 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1C1jOa-0000Iw-Ue
	for grub-devel@gnu.org; Mon, 30 Aug 2004 06:28:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1C1jOL-0000Hv-8K
	for grub-devel@gnu.org; Mon, 30 Aug 2004 06:28:05 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1C1jOH-0000Hk-IV
	for grub-devel@gnu.org; Mon, 30 Aug 2004 06:27:57 -0400
Received: from [212.43.237.68] (helo=kotoba.storever.com)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1C1jJR-0008Oz-ET
	for grub-devel@gnu.org; Mon, 30 Aug 2004 06:22:57 -0400
Received: from localhost (localhost [127.0.0.1])
	by kotoba.storever.com (Postfix) with ESMTP id 13E91F4C4A06
	for <grub-devel@gnu.org>; Mon, 30 Aug 2004 12:22:54 +0200 (CEST)
From: "Yoshinori K. Okuji" <okuji@enbug.org>
Organization: enbug.org
To: The development of GRUB 2 <grub-devel@gnu.org>
Date: Mon, 30 Aug 2004 12:22:55 +0200
User-Agent: KMail/1.6.1
References: <87vffat3zq.fsf@marco.marco-g.com>
	<87zn4f17fl.fsf@marco.marco-g.com>
In-Reply-To: <87zn4f17fl.fsf@marco.marco-g.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200408301222.55861.okuji@enbug.org>
Subject: Re: JFS support (PATCH) and filesystem improvements
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Aug 2004 10:28:17 -0000

On Saturday 28 August 2004 19:47, Marco Gerards wrote:
> Committed.

Thank you.

> And here is a patch for that.
>
> To avoid code duplication I wrote kern/fshelp.c, which has the
> following two functions:

That is a good idea, but why are the functions in the kernel? Imagine 
that GRUB 2 supports TFTP and the user uses GRUB as a network-based 
loader. Probably the user does not have to compile the helper 
functions, because network-based filesystems are very different at the 
implementation level.

So I think they should be in a module rather than the kernel. fshelp.mod 
sounds good for me.

Okuji