From: Ingo Molnar <mingo@elte.hu>
To: Nathan Lynch <nathanl@austin.ibm.com>
Cc: akpm@osdl.org, lkml <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] cpu hotplug fixes for dependent_sleeper and wake_sleeping_dependent
Date: Mon, 30 Aug 2004 15:29:25 +0200 [thread overview]
Message-ID: <20040830132925.GA1531@elte.hu> (raw)
In-Reply-To: <1093858876.11274.50.camel@biclops.private.network>
* Nathan Lynch <nathanl@austin.ibm.com> wrote:
> To recap, offlining a cpu with current bk results in the "Aiee,
> killing interrupt handler!" panic from do_exit(). This seems to be
> triggered only with CONFIG_PREEMPT and CONFIG_SCHED_SMT both enabled.
> I believe the problem is that when do_stop() calls schedule(),
> dependent_sleeper() drops the "offline" cpu's rq->lock and never
> reacquires it.
>
> The following seems to work (tested on ppc64). Is there a better way?
> - if (!(sd->flags & SD_SHARE_CPUPOWER))
> + if (!(sd->flags & SD_SHARE_CPUPOWER) || cpu_is_offline(this_cpu))
> + if (!(sd->flags & SD_SHARE_CPUPOWER) || cpu_is_offline(this_cpu))
it would really be nice to do this without any runtime overhead. Rusty?
Ingo
next prev parent reply other threads:[~2004-08-30 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-30 9:41 [PATCH] cpu hotplug fixes for dependent_sleeper and wake_sleeping_dependent Nathan Lynch
2004-08-30 13:29 ` Ingo Molnar [this message]
2004-09-01 23:25 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040830132925.GA1531@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathanl@austin.ibm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.