All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Roland McGrath <roland@redhat.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cleanup ptrace stops and remove notify_parent
Date: Mon, 30 Aug 2004 20:43:32 -0700	[thread overview]
Message-ID: <20040830204332.24da5615.akpm@osdl.org> (raw)
In-Reply-To: <200408310325.i7V3Pklo020920@magilla.sf.frob.com>

Roland McGrath <roland@redhat.com> wrote:
>
> This patch is against Linus's current tree.

It clashes significantly with your waitid syscall patch.  Which one do you
believe has priority?

> +	info.si_status = tsk->exit_code & 0x7f;
>  		if (tsk->exit_code & 0x80)
> -			why = CLD_DUMPED;
> +		info.si_code = CLD_DUMPED;
>  		else if (tsk->exit_code & 0x7f)
> -			why = CLD_KILLED;
> +		info.si_code = CLD_KILLED;
>  		else {
> -			why = CLD_EXITED;
> -			status = tsk->exit_code >> 8;
> -		}
> -		break;
> +		info.si_code = CLD_EXITED;
> +		info.si_status = tsk->exit_code >> 8;

Indenting catastrophe in do_notify_parent() needs fixing please.


  reply	other threads:[~2004-08-31  3:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-31  3:25 [PATCH] cleanup ptrace stops and remove notify_parent Roland McGrath
2004-08-31  3:43 ` Andrew Morton [this message]
2004-08-31  4:11   ` Roland McGrath
2004-08-31  4:26     ` Andrew Morton
2004-08-31  5:43       ` Roland McGrath
2004-08-31  4:27     ` Linus Torvalds
2004-08-31  4:50       ` Roland McGrath
2004-08-31 13:19       ` OGAWA Hirofumi
2004-08-31 13:56         ` Daniel Jacobowitz
2004-09-01  0:11         ` Roland McGrath
2004-09-01  4:25           ` OGAWA Hirofumi
2004-08-31  9:29     ` Christoph Hellwig
2004-08-31  9:43       ` Anton Blanchard
2004-09-01  0:00         ` Roland McGrath
2004-08-31  3:59 ` Roland McGrath
2004-08-31  4:22 ` Daniel Jacobowitz
2004-08-31  4:55   ` Roland McGrath
2004-08-31  4:59     ` Daniel Jacobowitz
     [not found] <2z7vs-2F1-13@gated-at.bofh.it>
2004-08-31 10:00 ` Andi Kleen
2004-09-01  0:27   ` Roland McGrath
2004-09-01  1:56     ` Roland McGrath
2004-09-04 13:38       ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2004-08-31 15:59 Albert Cahalan
2004-08-31 23:54 ` Roland McGrath
2004-09-01  0:27   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040830204332.24da5615.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.