From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: shemminger@osdl.org, netdev@oss.sgi.com
Subject: Re: neigh_create/inetdev_destroy race?
Date: Mon, 30 Aug 2004 23:08:20 -0700 [thread overview]
Message-ID: <20040830230820.7514985d.davem@davemloft.net> (raw)
In-Reply-To: <20040829065031.GA786@gondor.apana.org.au>
On Sun, 29 Aug 2004 16:50:31 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > Secondly, until neigh_create() takes the tbl lock, it is not in
> > the hash tables and therefore neigh_ifdown() could not see it.
>
> That part I agree with :) That's in fact what this race is about:
> neigh_ifdown does not guarantee that the hash table will be without
> references to idev.
I think we can clear this by putting neigh_parms_release() into an
RCU handler. It can't be in in_dev_rcu_put.
I also now believe that these sorts of races you are mentioning percolate
out into ip_mc_destroy_dev().
next prev parent reply other threads:[~2004-08-31 6:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-12 23:59 [PATCH] Move inetdev/ifa over to RCU David S. Miller
2004-08-13 2:20 ` James Morris
2004-08-13 10:02 ` Herbert Xu
2004-08-13 16:03 ` Stephen Hemminger
2004-08-13 16:38 ` David S. Miller
2004-08-13 21:56 ` Herbert Xu
2004-08-13 22:19 ` David S. Miller
2004-08-14 0:34 ` Herbert Xu
2004-08-14 0:39 ` David S. Miller
2004-08-14 0:54 ` Herbert Xu
2004-08-14 1:25 ` Herbert Xu
2004-08-14 1:30 ` Herbert Xu
2004-08-14 5:08 ` Herbert Xu
2004-08-14 6:27 ` neigh_create/inetdev_destroy race? Herbert Xu
2004-08-16 2:14 ` David S. Miller
2004-08-16 10:51 ` Herbert Xu
2004-08-29 6:42 ` David S. Miller
2004-08-29 6:50 ` Herbert Xu
2004-08-31 6:08 ` David S. Miller [this message]
2004-08-31 10:41 ` Herbert Xu
2004-09-02 5:21 ` David S. Miller
2004-09-02 13:06 ` Herbert Xu
2004-09-03 13:36 ` Herbert Xu
2004-09-03 16:00 ` Stephen Hemminger
2004-09-03 23:49 ` Herbert Xu
2004-09-07 20:50 ` David S. Miller
2004-09-03 16:18 ` David S. Miller
2004-08-16 2:08 ` [PATCH] Move inetdev/ifa over to RCU David S. Miller
2004-08-16 2:43 ` Herbert Xu
2004-08-16 3:08 ` David S. Miller
2004-08-16 3:14 ` Herbert Xu
2004-08-16 6:23 ` David S. Miller
2004-08-14 6:31 ` Herbert Xu
2004-08-14 6:32 ` Herbert Xu
2004-08-16 3:01 ` David S. Miller
2004-08-14 1:40 ` Herbert Xu
2004-08-16 3:03 ` David S. Miller
2004-08-16 3:23 ` Herbert Xu
2004-08-16 6:24 ` David S. Miller
2004-08-14 4:30 ` Stephen Hemminger
2004-08-14 4:36 ` Herbert Xu
2004-08-16 2:59 ` David S. Miller
2004-08-16 2:58 ` David S. Miller
2004-08-16 3:08 ` Herbert Xu
2004-08-16 6:21 ` David S. Miller
2004-08-16 8:13 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040830230820.7514985d.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.