All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: yoshfuji@linux-ipv6.org, herbert@debian.org, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6]: Fix suboptimal fragment sizing for last fragment
Date: Thu, 2 Sep 2004 14:44:36 -0700	[thread overview]
Message-ID: <20040902144436.2c8c1337.davem@redhat.com> (raw)
In-Reply-To: <4137681D.3000902@trash.net>

On Thu, 02 Sep 2004 20:36:13 +0200
Patrick McHardy <kaber@trash.net> wrote:

> This patch always builds mtu sized fragments and truncates the previous
> fragment to a multiple of 8 bytes when allocating a new one. With the
> patch the dump looks like this:

Looks great Patrick, applied.

I see only one remaining possible improvement.  If the fraggap
area is paged data, we probably should try use page frags
in the new SKB if this split occurs in ip_append_page().

  parent reply	other threads:[~2004-09-02 21:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-02 18:36 [PATCH 2.6]: Fix suboptimal fragment sizing for last fragment Patrick McHardy
2004-09-02 19:48 ` YOSHIFUJI Hideaki / 吉藤英明
2004-09-02 21:44 ` David S. Miller [this message]
2004-09-02 22:03   ` Herbert Xu
2004-09-02 22:08     ` David S. Miller
2004-09-03  1:40     ` YOSHIFUJI Hideaki / 吉藤英明
2004-09-07 20:35       ` David S. Miller
2004-09-07 23:15       ` Herbert Xu
2004-09-07 23:26         ` YOSHIFUJI Hideaki / 吉藤英明
2004-09-08  3:21           ` Herbert Xu
2004-09-08 20:38             ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040902144436.2c8c1337.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=herbert@debian.org \
    --cc=kaber@trash.net \
    --cc=netdev@oss.sgi.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.