Re: [PATCH] Fix possible leak in fbcon code. (fwd)

[Dave Jones <davej@redhat.com>]

On Fri, Sep 03, 2004 at 04:39:36AM +0800, Antonino A. Daplas wrote:
 > On Thursday 02 September 2004 17:45, Geert Uytterhoeven wrote:
 > > ---------- Forwarded message ----------
 > > Date: Wed, 1 Sep 2004 16:51:22 +0100
 > > From: Dave Jones <davej@redhat.com>
 > > To: linux-kernel@vger.kernel.org
 > > Subject: [PATCH] Fix possible leak in fbcon code.
 > >
 > > Spotted with the source checker from Coverity.com.
 > 
 > No, I don't think there's a leak in the original code. It always passes
 > through this part:
 > 
 > 	if (save) {
 > 		q = (unsigned short *) (vc->vc_origin +
 > 					vc->vc_size_row *
 > 					rows);
 > 		scr_memcpyw(q, save, logo_lines * new_cols * 2);
 > 		vc->vc_y += logo_lines;
 > 		vc->vc_pos += logo_lines * vc->vc_size_row;
 > 		kfree(save);
 > 	}
 > 
 > Tony

Ah, indeed you are correct. This code used to be wrapped inside
a if (!init), which if false, would have been a leak. That code
has been nuked since the coverity folks last did a run against
the tree.

I'll try and coerce the coverity folks into running against
something more recent when 2.6.9 comes out.

Linus, please drop the patch I sent you earlier against drivers/video/console/fbcon.c

		Dave



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click