All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Rosenkraenzer <bero@arklinux.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.6.9-rc1-mm3 i8042 compilation
Date: Fri, 3 Sep 2004 09:43:10 +0200	[thread overview]
Message-ID: <200409030943.10516.bero@arklinux.org> (raw)
In-Reply-To: <20040903014811.6247d47d.akpm@osdl.org>

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Friday 03 September 2004 10:48, Andrew Morton wrote:
> +acpi-based-i8042-keyboard-aux-controller-enumeration.patch

This one is broken:

drivers/input/serio/i8042.c: In function `acpi_i8042_kbd_add':
drivers/input/serio/i8042.c:1133: error: `i8042_data_reg' undeclared (first 
usein this function)
drivers/input/serio/i8042.c:1133: error: (Each undeclared identifier is 
reported only once
drivers/input/serio/i8042.c:1133: error: for each function it appears in.)
drivers/input/serio/i8042.c:1134: error: `i8042_command_reg' undeclared (first 
use in this function)
drivers/input/serio/i8042.c:1135: error: `i8042_status_reg' undeclared (first 
use in this function)

Looks like it's assigning values to variables that are neither declared nor 
used anywhere - so the fix is fairly easy (attached).

LLaP
bero

[-- Attachment #2: linux-2.6.9-rc1-mm3-i8042-compile.patch --]
[-- Type: text/x-diff, Size: 434 bytes --]

--- linux-2.6.8/drivers/input/serio/i8042.c.ark	2004-09-03 09:40:56.000000000 +0200
+++ linux-2.6.8/drivers/input/serio/i8042.c	2004-09-03 09:41:12.000000000 +0200
@@ -1130,9 +1130,6 @@
 		acpi_device_name(device), acpi_device_bid(device),
 		i8042.port1, i8042.port2, i8042.irq);
 
-	i8042_data_reg = i8042.port1;
-	i8042_command_reg = i8042.port2;
-	i8042_status_reg = i8042.port2;
 	i8042_kbd_values.irq = i8042.irq;
 
 	return 0;

  reply	other threads:[~2004-09-03  9:48 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-03  8:48 2.6.9-rc1-mm3 Andrew Morton
2004-09-03  7:43 ` Bernhard Rosenkraenzer [this message]
2004-09-03  9:47   ` [PATCH] 2.6.9-rc1-mm3 i8042 compilation Andrew Morton
2004-09-03  9:20 ` 2.6.9-rc1-mm3 Russell King
2004-09-03  9:42 ` 2.6.9-rc1-mm3 Christoph Hellwig
2004-09-03 12:15   ` 2.6.9-rc1-mm3 Zwane Mwaikambo
2004-09-03 12:25     ` 2.6.9-rc1-mm3 Christoph Hellwig
2004-09-03 12:48     ` 2.6.9-rc1-mm3 Zwane Mwaikambo
2004-09-06 12:55       ` [PATCH 2.6.9-rc1-mm3] [m32r] Change from EXPORT_SYMBOL_NOVERS to EXPORT_SYMBOL Hirokazu Takata
2004-09-06 13:11         ` Sam Ravnborg
2004-09-06 13:55           ` Russell King
2004-09-06 13:52       ` EXPORT_SYMBOL_NOVERS (was: Re: 2.6.9-rc1-mm3) Geert Uytterhoeven
2004-09-06 15:30         ` Zwane Mwaikambo
2004-09-06 19:09           ` [PATCH 0/4] " Geert Uytterhoeven
2004-09-08 14:18             ` Zwane Mwaikambo
2004-09-06 19:09           ` [PATCH 1/4] " Geert Uytterhoeven
2004-09-06 19:09           ` [PATCH 2/4] " Geert Uytterhoeven
2004-09-06 19:10           ` [PATCH 3/4] " Geert Uytterhoeven
2004-09-06 19:10           ` [PATCH 4/4] " Geert Uytterhoeven
2004-09-03  9:54 ` 2.6.9-rc1-mm3 Christoph Hellwig
2004-09-06 12:40   ` [PATCH 2.6.9-rc1-mm3] [m32r] Modify sys_ipc() to remove useless iBCS2 support code Hirokazu Takata
2004-09-06 17:03     ` Christoph Hellwig
2004-09-06 21:02     ` Andrew Morton
2004-09-06 21:08       ` Christoph Hellwig
2004-09-07  8:02     ` Arnd Bergmann
2004-09-03  9:57 ` 2.6.9-rc1-mm3 Christoph Hellwig
2004-09-03 11:08 ` 2.6.9-rc1-mm3 Hirokazu Takata
2004-09-03 12:08 ` 2.6.9-rc1-mm3 Zwane Mwaikambo
2004-09-03 15:15 ` 2.6.9-rc1-mm3 Norberto Bensa
2004-09-03 16:27   ` 2.6.9-rc1-mm3 Andrew Morton
2004-09-03 17:20     ` 2.6.9-rc1-mm3 Norberto Bensa
2004-09-05 19:59       ` 2.6.9-rc1-mm3 Norberto Bensa
2004-09-05 22:32         ` 2.6.9-rc1-mm3 Andrew Morton
2004-09-05 22:42           ` 2.6.9-rc1-mm3 Nathan Scott
2004-09-03 15:59 ` 2.6.9-rc1-mm3 Peter Osterlund
2004-09-03 16:37   ` 2.6.9-rc1-mm3 Andrew Morton
2004-09-05  8:59     ` 2.6.9-rc1-mm3 Peter Osterlund
2004-09-03 17:23 ` 2.6.9-rc1-mm3 William Lee Irwin III
2004-09-03 17:51   ` 2.6.9-rc1-mm3 Paulo Marques
2004-09-03 18:02     ` 2.6.9-rc1-mm3 William Lee Irwin III
2004-09-05 22:33       ` 2.6.9-rc1-mm3 Paulo Marques
2004-09-07 10:54         ` 2.6.9-rc1-mm3 Paulo Marques
2004-09-03 17:56 ` 2.6.9-rc1-mm3 Andre Eisenbach
2004-09-03 18:12   ` 2.6.9-rc1-mm3 William Lee Irwin III
2004-09-03 18:19     ` 2.6.9-rc1-mm3 Andre Eisenbach
2004-09-03 20:33   ` 2.6.9-rc1-mm3 Andrew Morton
2004-09-03 21:15     ` 2.6.9-rc1-mm3 Andre Eisenbach
2004-09-03 17:57 ` 2.6.9-rc1-mm3 (compile stats) John Cherry
2004-09-03 21:53 ` 2.6.9-rc1-mm3 William Lee Irwin III
2004-09-03 22:25 ` 2.6.9-rc1-mm3 William Lee Irwin III
2004-09-04 10:21 ` [patch] 2.6.9-rc1-mm3: char/riscom8.c doesn't compile Adrian Bunk
2004-09-04 17:52 ` [patch] 2.6.9-rc1-mm3: cdrom/cdu31a.c " Adrian Bunk
2004-09-08 22:29 ` 2.6.9-rc1-mm3 Dominik Karall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200409030943.10516.bero@arklinux.org \
    --to=bero@arklinux.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.