From: Andi Kleen <ak@suse.de>
To: Roland Dreier <roland@topspin.com>
Cc: Andi Kleen <ak@suse.de>,
jakub@redhat.com, ecd@skynet.be, pavel@suse.cz,
discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [discuss] Re: [PATCH] fs/compat.c: rwsem instead of BKL around ioctl32_hash_table
Date: Fri, 3 Sep 2004 17:02:41 +0200 [thread overview]
Message-ID: <20040903150241.GA12956@wotan.suse.de> (raw)
In-Reply-To: <52r7pjs8pw.fsf@topspin.com>
> Andi> If you wanted to fix it properly better make it use RCU -
> Andi> but it cannot work for the case of calling a compat handler.
>
> Based on what you just wrote, it seems to me like RCU would actually
> work fine. Is this wrong?
I meant it wouldn't work if you wanted to fix the module count assumption
I described above. Fixing it would be probably a good idea because it's a
bit of a nasty trap and kind of undocumented. But a global lock for
it is not the right way to do it, if anything you would use the
module counts.
-Andi
next prev parent reply other threads:[~2004-09-03 15:09 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 7:22 f_ops flag to speed up compatible ioctls in linux kernel Michael S. Tsirkin
2004-09-01 7:32 ` viro
2004-09-01 7:44 ` Michael S. Tsirkin
2004-09-01 7:47 ` Lee Revell
2004-09-01 8:19 ` Michael S. Tsirkin
2004-09-01 15:55 ` Roland Dreier
2004-09-01 18:02 ` Chris Wright
2004-09-01 18:12 ` Roland Dreier
2004-09-01 18:31 ` viro
2004-09-01 20:54 ` Roland Dreier
[not found] ` <20040901170800.K1924@build.pdx.osdl.net>
[not found] ` <20040901190122.L1924@build.pdx.osdl.net>
2004-09-02 3:46 ` Roland Dreier
2004-09-01 18:06 ` Bill Davidsen
2004-09-01 8:30 ` Arjan van de Ven
2004-09-01 15:40 ` [PATCH] fs/compat.c: rwsem instead of BKL around ioctl32_hash_table Roland Dreier
2004-09-01 23:27 ` Andrew Morton
2004-09-02 21:14 ` Andi Kleen
2004-09-02 22:26 ` Roland Dreier
2004-09-03 14:37 ` [discuss] " Andi Kleen
2004-09-03 14:55 ` Roland Dreier
2004-09-03 15:02 ` Andi Kleen [this message]
2004-09-03 8:00 ` [discuss] f_ops flag to speed up compatible ioctls in linux kernel Andi Kleen
2004-09-07 10:40 ` Michael S. Tsirkin
2004-09-07 12:14 ` Andi Kleen
2004-09-07 13:45 ` Michael S. Tsirkin
2004-09-07 14:15 ` Andi Kleen
2004-09-07 14:25 ` Michael S. Tsirkin
2004-09-07 14:29 ` Andi Kleen
2004-09-07 14:37 ` Michael S. Tsirkin
2004-09-07 14:44 ` Andi Kleen
2004-09-07 14:45 ` Michael S. Tsirkin
2004-09-07 15:10 ` Andi Kleen
2004-09-07 18:16 ` Michael S. Tsirkin
2004-09-08 6:55 ` Andi Kleen
2004-09-08 14:28 ` [patch] " Michael S. Tsirkin
2004-09-08 14:38 ` Andi Kleen
2004-09-08 14:54 ` Michael S. Tsirkin
2004-09-08 14:58 ` Andi Kleen
2004-09-12 20:05 ` Michael S. Tsirkin
2004-09-15 13:19 ` [patch] Re: [discuss] " Michael S. Tsirkin
2004-09-07 21:36 ` Is FIOQSIZE compatible? ( was Re: f_ops flag to speed up compatible ioctls in linux kernel) Michael S. Tsirkin
2004-09-08 6:54 ` Andi Kleen
2004-09-07 15:03 ` [discuss] f_ops flag to speed up compatible ioctls in linux kernel Herbert Poetzl
2004-09-07 18:07 ` Michael S. Tsirkin
2004-09-09 13:54 ` Herbert Poetzl
2004-12-12 21:51 ` how to detect a 32 bit process on 64 bit kernel Michael S. Tsirkin
2004-12-12 22:01 ` Jan Engelhardt
2004-12-12 22:23 ` Christoph Hellwig
2004-12-13 19:50 ` Michael S. Tsirkin
2004-12-13 21:01 ` Jan Engelhardt
2004-12-13 21:32 ` Brian Gerst
2004-12-13 21:37 ` Michael S. Tsirkin
2004-12-12 22:37 ` Willy Tarreau
2004-12-12 23:30 ` Bongani Hlope
2004-12-14 7:28 ` Andi Kleen
2004-09-20 14:49 ` [patch] speed up ioctls in linux kernel Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040903150241.GA12956@wotan.suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=ecd@skynet.be \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.