From: Dominik Brodowski <linux@dominikbrodowski.de>
To: davej@codemonkey.org.uk, jeremy@goop.org, cpufreq@www.linux.org.uk
Subject: [PATCH] cpufreq: speedstep-centrino should only decode MSR on certain CPUs
Date: Sat, 4 Sep 2004 09:55:07 +0200 [thread overview]
Message-ID: <20040904075507.GA3438@dominikbrodowski.de> (raw)
The encoding of the MSR only works as described in extract_clock() on
certain EST-enabled CPUs. So, limit the actual MSR check to these
CPUs.
Signed-off-by: Dominik Brodowski <linux@brodo.de>
diff -ruN linux-original/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c linux/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c
--- linux-original/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c 2004-08-30 22:50:56.000000000 +0200
+++ linux/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c 2004-09-04 09:48:49.044458312 +0200
@@ -77,7 +77,7 @@
/* Operating points for current CPU */
static struct cpu_model *centrino_model;
-static int centrino_cpu;
+static const struct cpu_id *centrino_cpu;
#ifdef CONFIG_X86_SPEEDSTEP_CENTRINO_TABLE
@@ -289,7 +289,9 @@
* for centrino, as some DSDTs are buggy.
* Ideally, this can be done using the acpi_data structure.
*/
- if (centrino_cpu) {
+ if ((centrino_cpu == &cpu_ids[CPU_BANIAS]) ||
+ (centrino_cpu == &cpu_ids[CPU_DOTHAN_A1]) ||
+ (centrino_cpu == &cpu_ids[CPU_DOTHAN_B0])) {
msr = (msr >> 8) & 0xff;
return msr * 100000;
}
@@ -457,7 +459,7 @@
break;
if (i != N_IDS)
- centrino_cpu = 1;
+ centrino_cpu = &cpu_ids[i];
if (centrino_cpu_init_acpi(policy)) {
if (policy->cpu != 0)
next reply other threads:[~2004-09-04 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-04 7:55 Dominik Brodowski [this message]
2004-09-09 1:45 ` [PATCH] cpufreq: speedstep-centrino should only decode MSR on certain CPUs Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040904075507.GA3438@dominikbrodowski.de \
--to=linux@dominikbrodowski.de \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@codemonkey.org.uk \
--cc=jeremy@goop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.