All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: linux-fsdevel@vger.kernel.org, shaggy@austin.ibm.com, jeffm@suse.com
Subject: Re: [PATCH] generic acl support for ->permission
Date: Sat, 4 Sep 2004 12:46:57 +0200	[thread overview]
Message-ID: <20040904104657.GA19114@lst.de> (raw)
In-Reply-To: <200409012120.53027.agruen@suse.de>

On Wed, Sep 01, 2004 at 09:20:52PM +0200, Andreas Gruenbacher wrote:
> Hello Christoph,
> 
> as far as I can see what you propose is very similar to the approach taken in 
> the attached patch, with one more indirection. This looks nicer to me, at the 
> cost of "polluting" iops instead of vfs_permission. JFS will still need 
> Dave's patch, obviously.
> 
> The attached patch only covers ext3; not sure if it even compiles.

I don't like this one conceptually.  checking a posix ACL isn't a
fundamental method for the inode object.  Checking permission is, and
checking the ACL as a subaspect of that should really be a callback and
not a method.


      reply	other threads:[~2004-09-04 10:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-01 15:24 [PATCH] generic acl support for ->permission Christoph Hellwig
2004-09-01 16:00 ` Christoph Hellwig
2004-09-01 17:40 ` Dave Kleikamp
2004-09-01 19:20 ` Andreas Gruenbacher
2004-09-04 10:46   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040904104657.GA19114@lst.de \
    --to=hch@lst.de \
    --cc=agruen@suse.de \
    --cc=jeffm@suse.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=shaggy@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.