From: Arjan van de Ven <arjanv@redhat.com>
To: Dave Airlie <airlied@linux.ie>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC/patch] macro_removal_agp_mtrr.diff
Date: Sat, 4 Sep 2004 15:30:50 +0200 [thread overview]
Message-ID: <20040904133050.GC15382@devserv.devel.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0409041418450.25475@skynet>
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
On Sat, Sep 04, 2004 at 02:23:30PM +0100, Dave Airlie wrote:
>
> Okay here is an updated patch:
>
> I've taken suggestions from Christoph and Arjan on board,
>
> My only issue is with the stuff in drm_os_linux.h, I've had to make a
> dummy AGP structure, and add the mtrr_add/mtrr_del stubs (as they are fine
> on x86 but don't exist on anything else..) but perhaps a small ugly in
> there is better than big uglies elsewhere...
I like it
> I might be able to drop the OS_HAS_AGP from the drivers, but that'll be a
> job that requires testing via CVS (as that is where we have the people
> with the different cards..)
well Rome wasn't built on one day either; this sure is a step in the right
direction.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-09-04 13:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-04 10:02 [RFC/patch] macro_removal_agp_mtrr.diff Dave Airlie
2004-09-04 10:11 ` Christoph Hellwig
2004-09-04 10:14 ` Arjan van de Ven
2004-09-04 10:21 ` Dave Airlie
2004-09-04 10:30 ` Dave Airlie
2004-09-04 10:36 ` Arjan van de Ven
2004-09-04 10:37 ` Arjan van de Ven
2004-09-04 13:23 ` Dave Airlie
2004-09-04 13:30 ` Arjan van de Ven [this message]
2004-09-04 15:47 ` Gene Heskett
2004-09-04 16:33 ` Alan Cox
2004-09-04 22:04 ` Lee Revell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040904133050.GC15382@devserv.devel.redhat.com \
--to=arjanv@redhat.com \
--cc=airlied@linux.ie \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.