From: Stephen Hemminger <shemminger@osdl.org>
To: David Miller <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH] bridge deadlock on device removal
Date: Mon, 6 Sep 2004 05:15:23 -0700 [thread overview]
Message-ID: <20040906051523.16e6a431@linux.site> (raw)
Fixes: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=131569
Dead lock in bridge when removing device interface module. br_del_if
assumes br->lock not held.
This fixes case of:
brctl addbr b0
brctl addif b0 eth0
rmmod eth0
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
diff -Nru a/net/bridge/br_notify.c b/net/bridge/br_notify.c
--- a/net/bridge/br_notify.c 2004-09-06 04:45:31 -07:00
+++ b/net/bridge/br_notify.c 2004-09-06 04:45:31 -07:00
@@ -76,10 +76,12 @@
break;
case NETDEV_UNREGISTER:
+ spin_unlock_bh(&br->lock);
br_del_if(br, dev);
- break;
+ goto done;
}
spin_unlock_bh(&br->lock);
+ done:
return NOTIFY_DONE;
}
next reply other threads:[~2004-09-06 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-06 12:15 Stephen Hemminger [this message]
2004-09-07 21:02 ` [PATCH] bridge deadlock on device removal David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040906051523.16e6a431@linux.site \
--to=shemminger@osdl.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.