From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: rusty@rustcorp.com.au, netfilter-devel@lists.netfilter.org,
kaber@trash.net
Subject: Re: [PATCH] Fix MASQUERADE
Date: Tue, 7 Sep 2004 14:32:07 -0700 [thread overview]
Message-ID: <20040907143207.03d51561.davem@davemloft.net> (raw)
In-Reply-To: <20040907213036.GA1587@gondor.apana.org.au>
On Wed, 8 Sep 2004 07:30:36 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Tue, Sep 07, 2004 at 08:09:44AM -0700, David S. Miller wrote:
> >
> > Didn't Herbert Xu et al. come to the conclusion that this isn't
> > the way to fix this and that using inet_select_addr() had
> > some problems especially in policy routing situations?
>
> No that was Julian Anastasov IIRC.
>
> I agree with Rusty and Harald that MASQUERADE should be as simple as
> possible. So if you need complex routing to determine the correct
> source address, then you should use SNAT.
>
> Now I haven't actually seen Rusty's patch but if it just uses
> inet_select_addr then it's definitely the way to go.
Hmmm, ok. Rusty, please resend to me under private cover.
prev parent reply other threads:[~2004-09-07 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 14:20 [PATCH] Fix MASQUERADE Rusty Russell
2004-09-07 15:09 ` David S. Miller
2004-09-07 21:30 ` Herbert Xu
2004-09-07 21:32 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040907143207.03d51561.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.