Re: complex variable

[Jan-Benedict Glaw <jbglaw@lug-owl.de>]

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

On Tue, 2004-09-07 11:37:06 -0400, Huber, George K RDECOM CERDEC STCD SRI <George.K.Huber@us.army.mil>
wrote in message <E3E30069B061524E90BCEE4417E30661138525@monm207.monmouth.army.mil>:
> In addition to the previously given suggestions, I would suggest checking
> the return 
> value of fopen (it can fail), as well as printing out the error codes.  For
> example,
> I would recode the above as (note - this is uncompiled/tested code but is
> should
> give an example of what I mean):

Error checking is always a good idea :-)

> #include<stdlib.h>
> #include<complex.h>
> #include<stdio.h>
> #include<errno.h>
> 
> int main()
> {
>     FILE* fp=NULL;

No need to initialize *fp to NULL because you assign a value before it's
read for the first time. That'll only bloat the program :)

>     char  szName[] = "test_data.dat";
> 
>     if(NULL != (fp = fopen(szName, "rb")))
>     {
>         int N=32, i=0;
>         complex x, *in = NULL;
> 	  if(NULL != (in=malloc(sizeof(complex)*N)))
Same here -- no need to initialize *in.

MfG, JBG

-- 
Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481             _ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  _ _ O
 fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!   O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]