From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [Lhms-devel] [PATCH] ACPI based Memory Hotplug DriverPatch Date: Fri, 10 Sep 2004 09:33:39 -0600 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <200409100933.40293.bjorn.helgaas@hp.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Cc: "S, Naveen B" , Dave Hansen , lhms , "Tolentino, Matthew E" List-Id: linux-acpi@vger.kernel.org On Friday 10 September 2004 7:01 am, S, Naveen B wrote: > > If it ends up that all of the callers of remove_memory() prefer to gi= ve > > start and end addresses, we'll probably change the calling convention= at > > some point. =A0Whatever is most natural. >=20 > Looks good. This should avoid usage of +1. IMHO an "address, size" convention is much nicer than "start, end". I don't like "start, end" because (1) there's always the ambiguity of whether the last byte is included, and (2) zero-length ranges look funny (e.g., "0x0,0xffff"). "address, size" avoids both problems, and is already used by tons of kernel interfaces like ioremap(), the dma interfaces, verify_area(), memset(), etc, etc. ------------------------------------------------------- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php