From: Andi Kleen <ak@suse.de>
To: jamal <hadi@cyberus.ca>
Cc: "David S. Miller" <davem@davemloft.net>,
ak@suse.de, herbert@gondor.apana.org.au, netdev@oss.sgi.com
Subject: Re: [PATCH] NETIF_F_LLTX for devices 2
Date: Sat, 11 Sep 2004 16:21:16 +0200 [thread overview]
Message-ID: <20040911142116.GL4431@wotan.suse.de> (raw)
In-Reply-To: <1094823215.1121.129.camel@jzny.localdomain>
On Fri, Sep 10, 2004 at 09:33:35AM -0400, jamal wrote:
> On Wed, 2004-09-08 at 16:47, David S. Miller wrote:
>
> >
> > We are merely moving the sch_generic.c locking logic into the
> > drivers. The behavior is entirely equivalent except that one
> > level of unnecessary locking has been removed.
> >
> > I think his change is valid, will not break existing drivers (as
> > you mentioned as well Jamal), and works well for the cases he has
> > shown patches of. So I'm going to apply his patch.
> >
> > BTW, if we are really concerned about some existing driver returning
> > -1 from hard_start_xmit() without the new feature flag being enabled,
> > we can test for that and log a debugging message if it happens.
The -1 test is only done when LLTX is set. So even when a existing
driver does that it's fine. Only the drivers that set the new bit
need to be checked.
>
> I am not 100% happy but let me do some testing on it. Would the best
> image be the latest bk snapshot?
What exactly are you not happy about?
-Andi
next prev parent reply other threads:[~2004-09-11 14:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 12:05 [PATCH] NETIF_F_LLTX for devices 2 Andi Kleen
2004-09-07 21:39 ` David S. Miller
2004-09-07 21:53 ` jamal
2004-09-08 6:51 ` Andi Kleen
2004-09-08 7:07 ` Herbert Xu
2004-09-08 7:24 ` Andi Kleen
2004-09-08 7:47 ` jamal
2004-09-08 20:47 ` David S. Miller
2004-09-10 13:33 ` jamal
2004-09-10 23:02 ` David S. Miller
2004-09-11 14:21 ` Andi Kleen [this message]
2004-09-11 20:15 ` jamal
2004-09-12 0:45 ` David S. Miller
2004-09-12 9:57 ` Jeff Garzik
2004-09-12 10:01 ` Jeff Garzik
2004-09-12 10:25 ` Andi Kleen
2004-09-12 11:03 ` Francois Romieu
2004-09-13 0:13 ` David S. Miller
2004-09-12 16:16 ` Jeff Garzik
2004-09-12 17:34 ` jamal
2004-09-13 0:06 ` Jeff Garzik
2004-09-13 0:10 ` David S. Miller
2004-09-13 2:52 ` Andrew Grover
2004-09-13 6:59 ` Andi Kleen
2004-09-13 16:10 ` Jeff Garzik
2004-09-13 0:12 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040911142116.GL4431@wotan.suse.de \
--to=ak@suse.de \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.