From: Christoph Hellwig <hch@lst.de>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] refactor tmscsim inititalization code
Date: Sun, 12 Sep 2004 13:37:27 +0200 [thread overview]
Message-ID: <20040912113727.GA32682@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.60.0409071812550.21209@poirot.grange>
On Tue, Sep 07, 2004 at 06:29:41PM +0200, Guennadi Liakhovetski wrote:
> >+static void __devinit dc390_eeprom_prepare_read(struct pci_dev *pdev, u8
> >cd)
> >{
> >+ u8 carryFlag = 1, j = 0x80, i, bval, regval;
> >
> >+ for (i = 0; i < 9; i++) {
> >+ if (carryFlag) {
> >+ bval = 0x40;
> >+ regval = 0x80;
> >+
> >+ pci_write_config_byte(pdev, regval, bval);
> >+ } else {
> >+ bval = 0;
> >+ regval = 0xc0;
>
> ^^^^^^^^^^^^^^
>
> Where does this come from? The old code seems to always write to 0x80,
> IIUC. I'll look further.
The 0xc0 is set in dc390_EnDisableCE when the first argument is
ENABLE_CE.
That happens just before the dc390_Prepare call in dc390_ReadEEprom
which is the only caller of dc390_EEpromOutDI.
next prev parent reply other threads:[~2004-09-12 11:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-04 13:02 [PATCH] refactor tmscsim inititalization code Christoph Hellwig
2004-09-07 15:29 ` [RFTesters] " Guennadi Liakhovetski
2004-09-10 13:32 ` Christoph Hellwig
2004-09-17 19:05 ` Guennadi Liakhovetski
2004-09-20 15:24 ` Christoph Hellwig
2004-09-20 20:35 ` Guennadi Liakhovetski
2004-09-21 5:41 ` Guennadi Liakhovetski
2004-09-07 16:29 ` Guennadi Liakhovetski
2004-09-12 11:37 ` Christoph Hellwig [this message]
2004-09-17 19:49 ` Guennadi Liakhovetski
2004-09-18 20:43 ` Guennadi Liakhovetski
2004-09-14 19:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040912113727.GA32682@lst.de \
--to=hch@lst.de \
--cc=g.liakhovetski@gmx.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.