From: William Lee Irwin III <wli@holomorphy.com>
To: Kirill Korotaev <dev@sw.ru>
Cc: Roel van der Made <roel@telegraafnet.nl>,
linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org
Subject: Re: [PATCH]: Re: kernel 2.6.9-rc1-mm4 oops
Date: Mon, 13 Sep 2004 01:05:42 -0700 [thread overview]
Message-ID: <20040913080542.GX2660@holomorphy.com> (raw)
In-Reply-To: <4145550F.8030601@sw.ru>
On Mon, Sep 13, 2004 at 12:06:39PM +0400, Kirill Korotaev wrote:
> --- ./kernel/exit.c.nt 2004-09-13 11:18:26.000000000 +0400
> +++ ./kernel/exit.c 2004-09-13 11:53:23.611075360 +0400
> @@ -848,10 +848,7 @@ asmlinkage long sys_exit(int error_code)
> task_t fastcall *next_thread(const task_t *p)
> {
> #ifdef CONFIG_SMP
> - if (!p->sighand)
> - BUG();
> - if (!spin_is_locked(&p->sighand->siglock) &&
> - !rwlock_is_locked(&tasklist_lock))
> + if (!rwlock_is_locked(&tasklist_lock))
> BUG();
> #endif
> return pid_task(p->pids[PIDTYPE_TGID].pid_list.next, PIDTYPE_TGID);
Hmm, BUG_ON() for whatever users (embedded?) that define BUG()/BUG_ON()
checks to nops may be useful here since no side effects are expected
from rwlock_is_locked().
FWIW I got this once while running initscripts(!) on a 4x logical x86-64
on virgin 2.6.9-rc1-mm4 but couldn't reproduce it.
-- wli
next prev parent reply other threads:[~2004-09-13 8:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 18:48 kernel 2.6.9-rc1-mm4 oops Roel van der Made
2004-09-13 8:06 ` [PATCH]: " Kirill Korotaev
2004-09-13 8:05 ` William Lee Irwin III [this message]
2004-09-13 8:31 ` Ingo Molnar
2004-09-13 9:15 ` Kirill Korotaev
2004-09-13 9:24 ` Ingo Molnar
2004-09-13 13:34 ` Roel van der Made
2004-09-13 13:38 ` Ingo Molnar
2004-09-13 13:42 ` Roel van der Made
2004-09-13 15:03 ` Kirill Korotaev
2004-09-13 14:39 ` Kirill Korotaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040913080542.GX2660@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=dev@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=roel@telegraafnet.nl \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.