From: Christoph Hellwig <hch@lst.de>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fix reiser4 compilation for ->permission changes
Date: Mon, 13 Sep 2004 16:02:26 +0200 [thread overview]
Message-ID: <20040913140226.GA23510@lst.de> (raw)
remove reiser4 permission. It only ends up calling generic_permission
with no additional bits so it's completely unessecary.
--- reiser4/fs/reiser4/inode_ops.c~ 2004-09-13 16:01:33.692057520 +0200
+++ reiser4/fs/reiser4/inode_ops.c 2004-09-13 16:01:48.759766880 +0200
@@ -64,7 +64,6 @@
static int reiser4_readlink(struct dentry *, char *, int);
static int reiser4_follow_link(struct dentry *, struct nameidata *);
static void reiser4_truncate(struct inode *);
-static int reiser4_permission(struct inode *, int, struct nameidata *);
static int reiser4_setattr(struct dentry *, struct iattr *);
static int reiser4_getattr(struct vfsmount *mnt, struct dentry *, struct kstat *);
@@ -394,22 +393,6 @@
reiser4_exit_context(&ctx);
}
-/* ->permission() method in reiser4_inode_operations. */
-static int
-reiser4_permission(struct inode *inode /* object */ ,
- int mask, /* mode bits to check permissions
- * for */
- struct nameidata *nameidata)
-{
- /* reiser4_context creation/destruction removed from here,
- because permission checks currently don't require this.
-
- Permission plugin have to create context itself if necessary. */
- assert("nikita-1687", inode != NULL);
-
- return perm_chk(inode, mask, inode, mask);
-}
-
/* common part of both unlink and rmdir. */
static int
unlink_file(struct inode *parent /* parent directory */ ,
@@ -615,7 +598,6 @@
.readlink = NULL,
.follow_link = NULL,
.truncate = reiser4_truncate, /* d */
- .permission = reiser4_permission, /* d */
.setattr = reiser4_setattr, /* d */
.getattr = reiser4_getattr, /* d */
};
next reply other threads:[~2004-09-13 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 14:02 Christoph Hellwig [this message]
2004-09-13 14:04 ` [PATCH] fix reiser4 compilation for ->permission changes Christoph Hellwig
2004-09-13 17:09 ` Alex Zarochentsev
2004-09-13 17:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040913140226.GA23510@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.