From: Tonnerre <tonnerre@thundrix.ch>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Hugh Dickins <hugh@veritas.com>,
Alex Zarochentsev <zam@namesys.com>, Paul Jackson <pj@sgi.com>,
William Lee Irwin III <wli@holomorphy.com>,
Hans Reiser <reiser@namesys.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test
Date: Mon, 13 Sep 2004 22:03:59 +0200 [thread overview]
Message-ID: <20040913200359.GE19399@thundrix.ch> (raw)
In-Reply-To: <Pine.LNX.4.61.0409131731400.877@scrub.home>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
Salut,
On Mon, Sep 13, 2004 at 06:03:28PM +0200, Roman Zippel wrote:
> +#define atomic_add_and_test(i,v) (atomic_add_return((i), (v)) == 0)
> +#define atomic_sub_and_test(i,v) (atomic_sub_return((i), (v)) == 0)
This is no longer atomic, is it? I mean, there's no guarantee that the
atomic_add_return and the comparison are executed without
interruption, is there?
I wonder whether it's supposed to be..
> #define atomic_sub(i, v) atomic_sub_return(i, v)
Maybe for some compilers we should cast away the result?
Tonnerre
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-09-13 20:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 10:12 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test Paul Jackson
2004-09-12 10:54 ` William Lee Irwin III
2004-09-12 16:33 ` Alex Zarochentsev
2004-09-12 18:49 ` Paul Jackson
2004-09-12 19:48 ` Alex Zarochentsev
2004-09-13 12:42 ` Hugh Dickins
2004-09-13 13:25 ` Roman Zippel
2004-09-13 13:51 ` Hugh Dickins
2004-09-13 14:10 ` Roman Zippel
2004-09-13 14:58 ` Hugh Dickins
2004-09-13 16:03 ` Roman Zippel
2004-09-13 16:20 ` Hugh Dickins
2004-09-13 20:03 ` Tonnerre [this message]
2004-09-13 20:18 ` Roman Zippel
2004-09-13 20:18 ` 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_s ub_and_test Hugh Dickins
2004-09-13 17:19 ` 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test Alex Zarochentsev
2004-09-14 2:06 ` William Lee Irwin III
2004-09-14 9:00 ` Roman Zippel
2004-09-14 9:10 ` William Lee Irwin III
2004-09-14 9:15 ` [sparc32] add atomic_sub_and_test() to make reiser4 code microoptimized for x86 compile on sparc32 William Lee Irwin III
2004-09-14 15:38 ` William Lee Irwin III
-- strict thread matches above, loose matches on Subject: below --
2004-09-13 17:14 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test Martin Schwidefsky
2004-09-13 17:26 ` Roman Zippel
[not found] <OF6D4E73AE.1DB1AD2F-ON42256F0F.003132FF-42256F0F.00321365@de.ibm.com>
2004-09-14 9:40 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040913200359.GE19399@thundrix.ch \
--to=tonnerre@thundrix.ch \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=reiser@namesys.com \
--cc=schwidefsky@de.ibm.com \
--cc=wli@holomorphy.com \
--cc=zam@namesys.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.