From: Ralf Baechle <ralf@linux-mips.org>
To: Peter Buckingham <peter@pantasys.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 2.6] fix mips atomic_lock declaration
Date: Tue, 14 Sep 2004 02:22:37 +0200 [thread overview]
Message-ID: <20040914002237.GA21739@linux-mips.org> (raw)
In-Reply-To: <41462025.9070607@pantasys.com>
On Mon, Sep 13, 2004 at 03:33:09PM -0700, Peter Buckingham wrote:
> diff -u -r1.36 atomic.h
> --- include/asm-mips/atomic.h 19 Aug 2004 09:54:23 -0000 1.36
> +++ include/asm-mips/atomic.h 13 Sep 2004 21:51:56 -0000
> @@ -26,7 +26,7 @@
> #include <asm/cpu-features.h>
> #include <asm/war.h>
>
> -extern spinlock_t atomic_lock;
> +static spinlock_t atomic_lock;
>
> typedef struct { volatile int counter; } atomic_t;
No. atomic_lock is intentionally undefined, so this patch seems very
broken.
Ralf
next prev parent reply other threads:[~2004-09-14 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 22:33 [PATCH 2.6] fix mips atomic_lock declaration Peter Buckingham
2004-09-14 0:22 ` Ralf Baechle [this message]
2004-09-14 0:24 ` Peter Buckingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914002237.GA21739@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=peter@pantasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.