From: Tonnerre <tonnerre@thundrix.ch>
To: Hanna Linder <hannal@us.ibm.com>,
ink@jurassic.park.msu.ru, linux-kernel@vger.kernel.org,
greg@kroah.com, wli@holomorphy.com
Subject: Re: [RFT 2.6.9-rc1 alpha sys_sio.c] [2/2] convert pci_find_device to pci_get_device
Date: Tue, 14 Sep 2004 04:21:25 +0200 [thread overview]
Message-ID: <20040914022125.GA20950@thundrix.ch> (raw)
In-Reply-To: <20040914020222.GB23058@twiddle.net>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
Salut,
On Mon, Sep 13, 2004 at 07:02:22PM -0700, Richard Henderson wrote:
> On Tue, Sep 14, 2004 at 02:29:33AM +0200, Tonnerre wrote:
> > > - while ((dev = pci_find_device(PCI_VENDOR_ID_NCR, PCI_ANY_ID, dev))) {
> > > + while ((dev = pci_get_device(PCI_VENDOR_ID_NCR, PCI_ANY_ID, dev))) {
> > > if (dev->device == PCI_DEVICE_ID_NCR_53C810
> > > || dev->device == PCI_DEVICE_ID_NCR_53C815
> > > || dev->device == PCI_DEVICE_ID_NCR_53C820
> >
> > Don't we need to put these devices in some place?
>
> pci_get_device does that for non-null "from" argument.
I was talking about pci_put_device(dev)..
Tonnerre
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-09-14 2:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 23:37 [RFT 2.6.9-rc1 alpha sys_sio.c] [2/2] convert pci_find_device to pci_get_device Hanna Linder
2004-09-14 0:29 ` Tonnerre
2004-09-14 2:02 ` Richard Henderson
2004-09-14 2:21 ` Tonnerre [this message]
2004-09-14 16:37 ` Hanna Linder
-- strict thread matches above, loose matches on Subject: below --
2004-09-14 22:56 Judith Lebzelter
2004-09-14 23:11 ` Hanna Linder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914022125.GA20950@thundrix.ch \
--to=tonnerre@thundrix.ch \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.