From: William Lee Irwin III <wli@holomorphy.com>
To: Hanna Linder <hannal@us.ibm.com>
Cc: rth@twiddle.net, ink@jurassic.park.msu.ru,
linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [RFT 2.6.9-rc1 alpha sys_alcor.c] [1/2] convert pci_find_device to pci_get_device
Date: Mon, 13 Sep 2004 20:17:05 -0700 [thread overview]
Message-ID: <20040914031705.GX9106@holomorphy.com> (raw)
In-Reply-To: <20040914020257.GF9106@holomorphy.com>
On Mon, Sep 13, 2004 at 04:37:13PM -0700, Hanna Linder wrote:
>> Here is a very simple patch to convert pci_find_device call to
>> pci_get_device. As I don't have an alpha box or cross compiler could
>> someone (wli- wink wink) please verify it compiles and doesn't break
>> anything, thanks a lot.
On Mon, Sep 13, 2004 at 07:02:57PM -0700, William Lee Irwin III wrote:
> I can run it through a compiler, but I won't be able to do meaningful
> runtime testing on it as I only have tincup and alphapc systems. They
> look safe at first glance.
More specifically, if these were merely alpha-specific drivers, I could
do meaningful testing as they would attempt to be detected this way.
But this is system-specific initialization executed conditionally on
the system type, so as the systems I have are not the ones affected by
these patches, if I were to attempt a runtime test I would merely
discover that the code was not executed.
-- wli
next prev parent reply other threads:[~2004-09-14 3:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 23:37 [RFT 2.6.9-rc1 alpha sys_alcor.c] [1/2] convert pci_find_device to pci_get_device Hanna Linder
2004-09-14 2:01 ` Richard Henderson
2004-09-14 2:14 ` William Lee Irwin III
2004-09-14 3:35 ` Greg KH
2004-09-14 2:02 ` William Lee Irwin III
2004-09-14 3:17 ` William Lee Irwin III [this message]
2004-09-14 15:52 ` Hanna Linder
2004-09-14 17:07 ` Herbert Poetzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914031705.GX9106@holomorphy.com \
--to=wli@holomorphy.com \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.