From: Greg KH <greg@kroah.com>
To: Borislav Petkov <petkov@uni-muenster.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: 2.6.9-rc1-mm4, visor.c, Badness in usb_unlink_urb
Date: Tue, 14 Sep 2004 00:47:39 -0700 [thread overview]
Message-ID: <20040914074739.GA22875@kroah.com> (raw)
In-Reply-To: <200409102024.32082.petkov@uni-muenster.de>
On Fri, Sep 10, 2004 at 08:24:31PM +0200, Borislav Petkov wrote:
> Hi Greg,
> I'll be happy to tackle the other drivers. Question: Does usb_unlink_urb have
> to be replaced only for synchronious unlinking
Yes.
> and if so, is the wrapping function responsible for checking the
> URB_ASYNC_UNLINK transfer flag? Here's a patch:
The driver should know how to shut down the urb.
> Signed-off-by: Borislav Petkov <petkov@uni-muenster.de>
>
> --- linux-2.6.9-rc1-mm/drivers/usb/class/audio.c.orig 2004-09-10 20:05:17.000000000 +0200
> +++ linux-2.6.9-rc1-mm/drivers/usb/class/audio.c 2004-09-10 20:23:12.000000000 +0200
> @@ -635,13 +635,13 @@ static void usbin_stop(struct usb_audiod
> spin_unlock_irqrestore(&as->lock, flags);
> if (notkilled && signal_pending(current)) {
> if (i & FLG_URB0RUNNING)
> - usb_unlink_urb(u->durb[0].urb);
> + usb_kill_urb(u->durb[0].urb);
Ick, the tabs are stripped out :(
thanks,
greg k-h
next prev parent reply other threads:[~2004-09-14 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-10 8:26 2.6.9-rc1-mm4, visor.c, Badness in usb_unlink_urb Norbert Preining
2004-09-10 9:45 ` [PATCH 0/2] " Borislav Petkov
2004-09-10 9:48 ` [PATCH 1/2] " Borislav Petkov
2004-09-10 14:01 ` Greg KH
2004-09-10 18:24 ` [PATCH] " Borislav Petkov
2004-09-14 7:47 ` Greg KH [this message]
2004-09-10 9:50 ` [PATCH 2/2] Re: 2.6.9-rc1-mm4, sub-serial.c, " Borislav Petkov
2004-09-10 14:30 ` 2.6.9-rc1-mm4, visor.c, " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914074739.GA22875@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=petkov@uni-muenster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.