From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [PATCH 4/5] atm/idt77252: replace
Date: Wed, 15 Sep 2004 18:20:02 +0000 [thread overview]
Message-ID: <20040915182002.GG4363@us.ibm.com> (raw)
In-Reply-To: <20040915181826.GE4363@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
Sorry, wrong subject line. Any comments would be appreciated.
Description: msleep_interruptible() is used instead of schedule_timeout()
to guarantee the task delays as expected. To achieve this, the timeout
variable is converted from an int to an unsigned long, and it's values
are changed accordingly.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc2-vanilla/drivers/atm/idt77252.c 2004-09-13 17:16:06.000000000 -0700
+++ 2.6.9-rc2/drivers/atm/idt77252.c 2004-09-14 11:34:25.000000000 -0700
@@ -2516,7 +2516,7 @@ idt77252_close(struct atm_vcc *vcc)
struct vc_map *vc = vcc->dev_data;
unsigned long flags;
unsigned long addr;
- int timeout;
+ unsigned long timeout;
down(&card->mutex);
@@ -2566,9 +2566,9 @@ done:
}
spin_unlock_irqrestore(&vc->lock, flags);
- timeout = 5 * HZ;
+ timeout = 5 * 1000;
while (atomic_read(&vc->scq->used) > 0) {
- timeout = schedule_timeout(timeout);
+ timeout = msleep_interruptible(timeout);
if (!timeout)
break;
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-09-15 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 18:18 [Kernel-janitors] [PATCH 4/5] atm/idt77252: replace Nishanth Aravamudan
2004-09-15 18:20 ` Nishanth Aravamudan [this message]
2004-09-16 7:06 ` Nishanth Aravamudan
2004-09-16 14:46 ` Randy.Dunlap
2004-09-16 14:57 ` Greg KH
2004-09-16 15:27 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040915182002.GG4363@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.