From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: J?rn Engel <joern@wohnheim.fh-wedel.de>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Being more anal about iospace accesses..
Date: Wed, 15 Sep 2004 13:06:29 -0700 [thread overview]
Message-ID: <20040915200629.GA24723@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0409151251060.2333@ppc970.osdl.org>
On Wed, Sep 15, 2004 at 12:53:51PM -0700, Linus Torvalds wrote:
>
>
> On Wed, 15 Sep 2004, Greg KH wrote:
> >
> > Currently a few drivers do:
> > status = readl(®s.status);
>
> I assume that's "®s->status", since regs had better be a pointer..
Yes, sorry.
> > which causes sparse warnings.
> >
> > How should that code be changed to prevent this? Convert them all to
> > ioread32()? Or figure out a way to supress the warning for readl()?
>
> Just make sure that you annotate "regs" as a pointer to IO space.
Ah, ok, that works. Thanks for the clarification, I now realize that
__iomem can be a marker for any type of pointer, not just a void.
That's where I was confused.
thanks,
greg k-h
next prev parent reply other threads:[~2004-09-15 20:11 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-08 22:57 RFC: being more anal about iospace accesses Linus Torvalds
2004-09-08 23:07 ` David S. Miller
2004-09-08 23:25 ` Linus Torvalds
2004-09-09 1:19 ` Linus Torvalds
2004-09-09 4:36 ` David S. Miller
2004-09-09 5:56 ` Richard Henderson
2004-09-09 5:04 ` viro
2004-09-09 5:05 ` David S. Miller
2004-09-09 5:13 ` Linus Torvalds
2004-09-09 6:08 ` viro
2004-09-09 8:27 ` Geert Uytterhoeven
2004-09-09 6:23 ` David Woodhouse
2004-09-09 13:14 ` Alan Cox
2004-09-11 6:09 ` Linus Torvalds
2004-09-11 6:42 ` Anton Blanchard
2004-09-11 7:26 ` Benjamin Herrenschmidt
2004-09-11 7:29 ` Geert Uytterhoeven
2004-09-11 7:23 ` Benjamin Herrenschmidt
2004-09-11 14:42 ` Alan Cox
2004-09-15 15:03 ` Linus Torvalds
2004-09-15 16:30 ` Being " Linus Torvalds
2004-09-15 16:54 ` Jörn Engel
2004-09-15 17:07 ` Linus Torvalds
2004-09-15 17:32 ` Jörn Engel
2004-09-15 17:57 ` Linus Torvalds
2004-09-15 18:06 ` Linus Torvalds
2004-09-15 19:34 ` Greg KH
2004-09-15 19:53 ` Linus Torvalds
2004-09-15 20:06 ` Greg KH [this message]
2004-09-16 14:58 ` Horst von Brand
2004-09-15 17:45 ` Nikita Danilov
2004-09-15 18:09 ` Linus Torvalds
2004-09-15 18:40 ` Chris Wedgwood
2004-09-15 17:07 ` Jeff Garzik
2004-09-15 17:16 ` Roland Dreier
2004-09-15 17:39 ` Linus Torvalds
2004-09-15 20:07 ` Russell King
2004-09-15 17:36 ` Horst von Brand
2004-09-15 17:40 ` Brian Gerst
2004-09-15 16:56 ` Dave Jones
2004-09-15 17:19 ` Roger Luethi
2004-09-15 17:23 ` Richard B. Johnson
2004-09-15 22:21 ` Deepak Saxena
2004-09-15 22:46 ` Linus Torvalds
2004-09-15 23:09 ` Deepak Saxena
2004-09-16 12:51 ` Geert Uytterhoeven
2004-09-16 22:10 ` Deepak Saxena
2004-09-15 22:29 ` Roland Dreier
2004-09-15 23:26 ` Being more careful " Linus Torvalds
2004-09-16 0:10 ` viro
2004-09-16 11:40 ` David Woodhouse
2004-09-16 12:25 ` David Woodhouse
2004-09-16 14:01 ` Linus Torvalds
2004-09-18 9:46 ` Kai Henningsen
2004-09-15 19:02 ` RFC: being more anal " Geert Uytterhoeven
2004-09-15 19:16 ` Linus Torvalds
2004-09-15 19:40 ` Matthew Wilcox
2004-09-15 20:10 ` Linus Torvalds
2004-09-15 20:17 ` Linus Torvalds
2004-09-16 12:17 ` David Woodhouse
2004-09-16 13:52 ` Linus Torvalds
2004-09-15 20:20 ` Russell King
2004-09-15 20:34 ` Linus Torvalds
2004-09-15 20:51 ` Linus Torvalds
2004-09-15 22:38 ` James Bottomley
2004-09-16 2:33 ` Matthew Wilcox
2004-09-16 4:28 ` Linus Torvalds
2004-09-16 4:57 ` Benjamin Herrenschmidt
2004-09-16 4:58 ` Benjamin Herrenschmidt
2004-09-16 13:41 ` Matthew Wilcox
2004-09-16 18:21 ` Linus Torvalds
2004-09-16 18:52 ` Jesse Barnes
2004-09-16 19:09 ` Linus Torvalds
2004-09-16 20:02 ` Jesse Barnes
2004-09-16 20:37 ` James Bottomley
2004-09-16 20:42 ` Jesse Barnes
2004-09-16 21:37 ` Grant Grundler
2004-09-16 20:04 ` David S. Miller
2004-09-16 20:13 ` Jeff Garzik
2004-09-16 20:45 ` David S. Miller
2004-09-16 20:20 ` Jesse Barnes
2004-09-17 5:17 ` Benjamin Herrenschmidt
2004-09-17 15:30 ` Jesse Barnes
2004-09-16 19:01 ` Linus Torvalds
2004-09-16 19:13 ` Jeff Garzik
2004-09-16 19:50 ` Linus Torvalds
2004-09-16 20:07 ` Alan Cox
2004-09-17 5:44 ` Benjamin Herrenschmidt
2004-09-17 5:20 ` Benjamin Herrenschmidt
2004-09-17 15:03 ` Linus Torvalds
2004-09-16 22:30 ` Matthew Wilcox
2004-09-16 22:42 ` Linus Torvalds
2004-09-16 22:46 ` Jeff Garzik
2004-09-16 23:15 ` Linus Torvalds
2004-09-16 23:30 ` Jeff Garzik
2004-09-16 23:43 ` Linus Torvalds
2004-09-17 12:44 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2004-09-15 18:25 Being " linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040915200629.GA24723@kroah.com \
--to=greg@kroah.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.