From: Paul Jackson <pj@sgi.com>
To: Simon Derr <Simon.Derr@bull.net>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch] cpusets: fix race in cpuset_add_file()
Date: Thu, 16 Sep 2004 07:55:01 -0700 [thread overview]
Message-ID: <20040916075501.20c3ee45.pj@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0409161548040.5423@openx3.frec.bull.fr>
Color me confused - this cpuset_sem down/up should not be needed,
and should deadlock. In the call chain:
cpuset_mkdir -> cpuset_create -> cpuset_populate_dir -> cpuset_add_file
cpuset_create() already holds the cpuset_sem for the duration, and you're
adding another cpuset_sem down in cpuset_add_file(), which should deadlock.
If you are seeing the duplicate invalid cpuset entries, then must be
something else going on, unfortunately.
That, or I'm confused.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
next prev parent reply other threads:[~2004-09-16 15:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 1:29 [Patch] cpusets: document proc status allowed fields Paul Jackson
2004-09-16 14:01 ` [Patch] cpusets: fix race in cpuset_add_file() Simon Derr
2004-09-16 14:55 ` Paul Jackson [this message]
2004-09-16 15:39 ` Simon Derr
2004-09-16 16:03 ` Paul Jackson
2004-09-17 7:22 ` Paul Jackson
2004-09-17 7:55 ` Simon Derr
2004-09-17 9:10 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916075501.20c3ee45.pj@sgi.com \
--to=pj@sgi.com \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.