From: Russell King <rmk+lkml@arm.linux.org.uk>
To: "Randy.Dunlap" <randy.dunlap@verizon.net>
Cc: mgreer@mvista.com, akpm <akpm@osdl.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: review MPSC driver
Date: Thu, 16 Sep 2004 11:17:09 +0100 [thread overview]
Message-ID: <20040916111709.C31029@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040915214301.53a68379.randy.dunlap@verizon.net>; from randy.dunlap@verizon.net on Wed, Sep 15, 2004 at 09:43:01PM -0700
On Wed, Sep 15, 2004 at 09:43:01PM -0700, Randy.Dunlap wrote:
> 3. + select SERIAL_CORE
> + select SERIAL_CORE_CONSOLE
>
> Please don't use "select". Use "depends on" instead.
This is actually (one of the few) correct uses of select. These two
symbols are *not* user visible, and are derived from the configuration
settings of the hardware drivers.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-09-16 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040915150247.37706f7c.rddunlap@osdl.org>
2004-09-16 4:43 ` review MPSC driver Randy.Dunlap
2004-09-16 8:10 ` Adrian Bunk
2004-09-16 15:21 ` Randy.Dunlap
2004-09-16 10:17 ` Russell King [this message]
2004-09-16 18:12 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916111709.C31029@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@mvista.com \
--cc=randy.dunlap@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.