Re: [PATCH] Suspend2 Merge: Driver model patches 0/2

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > Here are two patches for the driver model, which have been in use in
> > > suspend2 for around a month.
> > > 
> > > The first provides support for keeping part of the device tree alive
> > > while suspending the remainder. This is accomplished by abstracting the
> > > dpm_active, dpm_off and dpm_irq lists into a new struct partial device
> > 
> > I believe this is wrong approach.
> > 
> > For atomic snapshot to work, all devices need to be stopped. If your
> > video card does DMA, it needs to be stopped. So all drivers need to
> > know, you can not just exclude part of tree.
> 
> Sorry. Perhaps I wasn't clear enough. I do suspend these devices. But I
> do it later:
> 
> Suspend all other drivers.
> Write pageset 2 (page cache).
> Suspend used drivers.
> Make atomic copy.
> Resume used drivers.
> Write pageset 1 (atomic copy)
> Suspend used drivers.
> Power down all.

What is problem with:

Write pageset 2
Suspend all drivers (avoiding slow operations)
Make atomic copy
Resume all drivers (avoiding slow operations)
Write pageset 1
Suspend all drivers
Power down all.

?

> > Now, you probably do not want disks to spin down and you want your
> > screen unblanked (as an optimalization/speedup). Patch for keeping
> > disk up is allready in -mm. Patch for keeping radeonfb up looks like
> > this, and is pending, too.
> 
> Mm. Don't forget i8xx and the gazillion other drivers there :>. I see
> this is using the SYSTEM_SNAPSHOT value. Do those changes look like
> being merged to Linus soon?

I still hope so. Patrick is back, so it could be merged by the end of
week... if we are lucky.
								Pavel

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!