Re: [PATCH] Suspend2 Merge: Driver model patches 2/2

[Greg KH <greg@kroah.com>]

On Thu, Sep 16, 2004 at 08:58:51PM +1000, Nigel Cunningham wrote:
> 
> This simple helper adds support for finding a class given its name. I
> use this to locate the frame buffer drivers and move them to the
> keep-alive tree while suspending other drivers.
> 
> +struct class * class_find(char * name)
> +{
> +	struct class * this_class;
> +
> +	if (!name)
> +		return NULL;
> +
> +	list_for_each_entry(this_class, &class_subsys.kset.list, subsys.kset.kobj.entry) {
> +		if (!(strcmp(this_class->name, name)))
> +			return this_class;
> +	}
> +
> +	return NULL;
> +}

Ick, no.  I've been over this before with the fb people, and am not going
to accept this patch (nevermind that it's broken...)  See the lkml
archives for more info on why I don't like this.

thanks,

greg k-h