From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [PATCH 2.6.9-rc2 1/3] ide/ide-cd: replace
Date: Thu, 16 Sep 2004 23:11:14 +0000 [thread overview]
Message-ID: <20040916231114.GE1777@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
Any comments would be appreciated.
Description: Uses msleep() in place of cdrom_sleep()
to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc2-vanilla/drivers/ide/ide-cd.c 2004-09-13 17:16:06.000000000 -0700
+++ 2.6.9-rc2/drivers/ide/ide-cd.c 2004-09-14 13:52:14.000000000 -0700
@@ -1519,19 +1519,6 @@ static ide_startstop_t cdrom_do_packet_c
}
-/* Sleep for TIME jiffies.
- Not to be called from an interrupt handler. */
-static
-void cdrom_sleep (int time)
-{
- int sleep = time;
-
- do {
- set_current_state(TASK_INTERRUPTIBLE);
- sleep = schedule_timeout(sleep);
- } while (sleep);
-}
-
static
int cdrom_queue_packet_command(ide_drive_t *drive, struct request *rq)
{
@@ -1566,7 +1553,7 @@ int cdrom_queue_packet_command(ide_drive
/* The drive is in the process of loading
a disk. Retry, but wait a little to give
the drive time to complete the load. */
- cdrom_sleep(2 * HZ);
+ msleep(2000);
} else {
/* Otherwise, don't retry. */
retries = 0;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2004-09-16 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 23:11 Nishanth Aravamudan [this message]
2004-09-17 18:22 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/3] macintosh/macserial: Nishanth Aravamudan
2004-09-17 18:41 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/3] md/md: replace Nishanth Aravamudan
2004-09-24 23:06 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/3] parport/ieee1284: replace Nishanth Aravamudan
2004-09-27 23:09 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/3] video/radeon_base: replace Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916231114.GE1777@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.