Re: [PATCH 3 of 6] svcrpc: move export table checks to a per-program pg_add_client method

["J. Bruce Fields" <bfields@fieldses.org>]

On Thu, Sep 16, 2004 at 09:18:39PM -0400, Trond Myklebust wrote:
> You are making a special method that is really very specific to
> svcauth_unix and svcauth_null, yet the pg_set_client() appears as a
> generic method in the generic svc_program object.
> 
> Firstly, I'd strongly suggest that we call this callback pg_set_domain
> so that there is no confusion about what it does.

After considering that, I decided that "client" (which is used in
rq_client, in the nfsctl's (add_client), etc., in the exportfs
documentation, etc.) makes more sense than "domain" (used only in the
type struct auth_domain).

> Secondly, please explain why we're leaving RPCSEC_GSS as a special case
> here? Isn't the current implementation also calling up to "rpc.mountd"
> in order to check "/etc/exports"?

Yes, but that doesn't happen till later--we have to have a filehandle
for that.  The mistake was probably referring to "the export table" in
the patch comments--we're not really looking at that yet, we're only
looking up the name of this client--it's not much more than a reverse
dns lookup.  (So in the worst case, in auth_unix, there are *two*
upcalls--one here, to get the name of the client, then one later to
actually see whether something's exported to that client.)

So this upcall really is auth_unix/auth_null-specific.

But still there's some odd asymmetry here, I agree--I need to think
about the auth_gss case.

> Ideally, all the *_accept() methods
> should be calling the same function to set the domain (or not to set it
> as the case may be). Better still: could we defer calling
> pg_set_domain() until after the call to svc_authenticate?

That would be nice.

> Finally, please could we move the domain_release() method out of struct
> auth_ops and into struct auth_domain itself?

Yeah, that's probably a good idea.

Thanks for the comments.

--b.


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs