From: David Gibson <david@gibson.dropbear.id.au>
To: Andrew Morton <akpm@osdl.org>
Cc: David Miller <davem@redhat.com>,
trivial@rustcorp.com.au, linux-kernel@vger.kernel.org,
netdev@oss.sgi.com
Subject: [TRIVIAL] Fix recent bug in fib_semantics.c
Date: Fri, 17 Sep 2004 16:20:42 +1000 [thread overview]
Message-ID: <20040917062042.GE6523@zax> (raw)
Andrew, please apply:
When fib_create_info() allocates new hash tables, it neglects to
initialize them. This leads to an oops during boot on at least
machine I use. This patch addresses the problem.
Signed-off-by: David Gibson <dwg@au1.ibm.com>
Index: working-2.6/net/ipv4/fib_semantics.c
===================================================================
--- working-2.6.orig/net/ipv4/fib_semantics.c 2004-09-17 09:20:04.000000000 +1000
+++ working-2.6/net/ipv4/fib_semantics.c 2004-09-17 16:24:42.634638304 +1000
@@ -604,8 +604,12 @@
if (!new_info_hash || !new_laddrhash) {
fib_hash_free(new_info_hash, bytes);
fib_hash_free(new_laddrhash, bytes);
- } else
+ } else {
+ memset(new_info_hash, 0, bytes);
+ memset(new_laddrhash, 0, bytes);
+
fib_hash_move(new_info_hash, new_laddrhash, new_size);
+ }
if (!fib_hash_size)
goto failure;
--
David Gibson | For every complex problem there is a
david AT gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
next reply other threads:[~2004-09-17 6:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-17 6:20 David Gibson [this message]
2004-09-17 6:37 ` [TRIVIAL] Fix recent bug in fib_semantics.c Jeff Garzik
2004-09-17 18:27 ` David S. Miller
2004-09-18 0:21 ` Jon Smirl
2004-09-18 0:27 ` Herbert Xu
2004-09-18 0:59 ` Jon Smirl
2004-09-18 1:37 ` Jon Smirl
2004-09-18 4:16 ` Herbert Xu
2004-09-18 5:22 ` Jon Smirl
2004-09-18 6:31 ` David S. Miller
2004-09-18 15:28 ` Jon Smirl
2004-09-18 20:31 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040917062042.GE6523@zax \
--to=david@gibson.dropbear.id.au \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.