From: Phil Oester <kernel@linuxace.com>
To: netfilter-devel@lists.netfilter.org
Subject: [PATCH] psd option parsing
Date: Fri, 17 Sep 2004 16:49:02 -0700 [thread overview]
Message-ID: <20040917234902.GA1131@linuxace.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 311 bytes --]
psd match is too greedy with options, and doesn't play well with
other matches. For example:
# iptables -A INPUT -m psd -m recent --set -j DROP
iptables v1.2.11: missing optarg
Try `iptables -h' or 'iptables --help' for more information.
Below patch makes it less greedy.
This fixes bugzilla #18
Phil
[-- Attachment #2: patch-psd --]
[-- Type: text/plain, Size: 507 bytes --]
diff -ru ipt-orig/extensions/libipt_psd.c ipt-new/extensions/libipt_psd.c
--- ipt-orig/extensions/libipt_psd.c 2003-07-14 16:01:29.000000000 -0400
+++ ipt-new/extensions/libipt_psd.c 2004-09-17 19:44:33.900825504 -0400
@@ -84,11 +84,6 @@
struct ipt_psd_info *psdinfo = (struct ipt_psd_info *)(*match)->data;
unsigned int num;
- if (!optarg)
- exit_error(PARAMETER_PROBLEM, "missing optarg");
-
- /* string_to_number needs a leading space */
-
switch (c) {
/* PSD-weight-threshold */
case '1':
next reply other threads:[~2004-09-17 23:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-17 23:49 Phil Oester [this message]
2004-09-18 17:46 ` [PATCH] psd option parsing Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040917234902.GA1131@linuxace.com \
--to=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.