All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Langer <martin-langer@gmx.de>
To: alsa-devel@alsa-project.org
Subject: [PATCH] rme32 segfault fix
Date: Sun, 19 Sep 2004 22:10:18 +0200	[thread overview]
Message-ID: <20040919201017.GA512@tuba.home> (raw)

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]


Hi,

looks like rme32 in halfduplex mode is broken for playback (since v1.0.6).
You will get a segfault without this patch :(

Changes:
- disables buffer prefill in halfduplex mode, which fixes segmentation fault
  of rme32 for playback in halfduplex mode

Signed-Off by Martin Langer <martin-langer@gmx.de>


martin



[-- Attachment #2: rme32-halfduplex-fix.patch --]
[-- Type: text/plain, Size: 416 bytes --]

--- alsa-kernel/pci/rme32.c.ORIGINAL	Sun Sep 19 21:39:28 2004
+++ alsa-kernel/pci/rme32.c	Sun Sep 19 21:40:04 2004
@@ -1123,7 +1123,7 @@
 	}
 	
 	/* prefill playback buffer */
-	if (cmd == SNDRV_PCM_TRIGGER_START) {
+	if ((cmd == SNDRV_PCM_TRIGGER_START) && (rme32->fullduplex_mode)) {
 		snd_pcm_group_for_each(pos, substream) {
 			s = snd_pcm_group_substream_entry(pos);
 			if (s == rme32->playback_substream) {

             reply	other threads:[~2004-09-19 20:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-19 20:10 Martin Langer [this message]
2004-09-20 10:11 ` [PATCH] rme32 segfault fix Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040919201017.GA512@tuba.home \
    --to=martin-langer@gmx.de \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.