Re: [Kernel-janitors] pci_find_* to pci_get_*

[Greg KH <greg@kroah.com>]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

On Mon, Sep 20, 2004 at 12:39:44PM +0100, Matthew Wilcox wrote:
> On Mon, Sep 20, 2004 at 01:20:20AM -0700, Scott Feldman wrote:
> > diff -Nru a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> > --- a/drivers/net/e1000/e1000_main.c	2004-09-20 00:25:03 -07:00
> > +++ b/drivers/net/e1000/e1000_main.c	2004-09-20 00:25:03 -07:00
> > @@ -2789,9 +2789,10 @@
> >  	case SYS_DOWN:
> >  	case SYS_HALT:
> >  	case SYS_POWER_OFF:
> > -		while((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev))) {
> > +		while((pdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pdev))) {
> >  			if(pci_dev_driver(pdev) == &e1000_driver)
> >  				e1000_suspend(pdev, 3);
> > +			pci_dev_put(pdev);
> >  		}
> >  	}
> >  	return NOTIFY_DONE;
> 
> Ummm... there's still a race here.  Between the pci_dev_put() returning and
> the invocation of pci_get_device(), the pdev can go away.  I guess you have
> to do something like:

No you do not, please read the documentation for pci_get_device().
Actually this patch is incorrect for a different reason, that
pci_dev_put() is not needed at all, as pci_get_device() handles the put
on the device for you properly.

So, Scott, care to fix the patch?

Oh, and 1 patch per driver makes it easier for us to see these things :)

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors