From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: isdn/icn: change units of ICN_BOOT_TIMEOUT1
Date: Mon, 20 Sep 2004 16:04:41 +0000 [thread overview]
Message-ID: <20040920160441.GA1898@us.ibm.com> (raw)
In-Reply-To: <20040918211325.GA3609@masina.coderock.org>
[-- Attachment #1: Type: text/plain, Size: 2149 bytes --]
On Sat, Sep 18, 2004 at 11:13:25PM +0200, Domen Puncer wrote:
> On 17/09/04 10:52 -0700, Nishanth Aravamudan wrote:
> > Any comments would be appreciated. This is a re-push of a patch
> > submitted a few months ago which has not been merged as of
> > 2.6.9-rc1-mm5 / 2.6.9-rc2.
> >
> > Description: Change units of ICN_BOOT_TIMEOUT1 to msecs instead of
> > jiffies for msleep_interruptible() in icn.c. Also, remove unused
> > constant ICN_CHANLOCK_DELAY.
> >
> > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> >
> > --- 2.6.9-rc2-vanilla/drivers/isdn/icn/icn.h 2004-09-13 17:16:04.000000000 -0700
> > +++ 2.6.9-rc2/drivers/isdn/icn/icn.h 2004-09-17 10:43:35.000000000 -0700
> > @@ -70,8 +70,7 @@ typedef struct icn_cdef {
> > #define ICN_FLAGS_RUNNING 4 /* Cards driver activated */
> > #define ICN_FLAGS_RBTIMER 8 /* cyclic scheduling of B-Channel-poll */
> >
> > -#define ICN_BOOT_TIMEOUT1 (HZ) /* Delay for Boot-download (jiffies) */
> > -#define ICN_CHANLOCK_DELAY (HZ/10) /* Delay for Channel-mapping (jiffies) */
> > +#define ICN_BOOT_TIMEOUT1 (1000) /* Delay for Boot-download (jiffies) */
>
> Change comment to msecs too.
>
> And some nitpicking: :-)
> Numbers in defines don't have to be in ()'s.
> Also, code seem to have formated "*/", your patch breaks it.
Please find the corrected patch below. Thanks, Domen!
--- 2.6.9-rc2-vanilla/drivers/isdn/icn/icn.h 2004-09-13 17:16:04.000000000 -0700
+++ 2.6.9-rc2/drivers/isdn/icn/icn.h 2004-09-20 09:00:16.000000000 -0700
@@ -70,8 +70,7 @@ typedef struct icn_cdef {
#define ICN_FLAGS_RUNNING 4 /* Cards driver activated */
#define ICN_FLAGS_RBTIMER 8 /* cyclic scheduling of B-Channel-poll */
-#define ICN_BOOT_TIMEOUT1 (HZ) /* Delay for Boot-download (jiffies) */
-#define ICN_CHANLOCK_DELAY (HZ/10) /* Delay for Channel-mapping (jiffies) */
+#define ICN_BOOT_TIMEOUT1 1000 /* Delay for Boot-download (msecs) */
#define ICN_TIMER_BCREAD (HZ/100) /* B-Channel poll-cycle */
#define ICN_TIMER_DCREAD (HZ/2) /* D-Channel poll-cycle */
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-09-20 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-18 21:13 [Kernel-janitors] Re: isdn/icn: change units of ICN_BOOT_TIMEOUT1 Domen Puncer
2004-09-20 16:04 ` Nishanth Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040920160441.GA1898@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.