All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH 2.6 0/12]: netfilter update
Date: Tue, 21 Sep 2004 17:18:57 -0700	[thread overview]
Message-ID: <20040921171857.2c720c8e.davem@redhat.com> (raw)
In-Reply-To: <4150BB62.2060904@trash.net>

On Wed, 22 Sep 2004 01:38:10 +0200
Patrick McHardy <kaber@trash.net> wrote:

> Done. The updated tree is at the same location.

Thanks, two problems:

1) Please layout the new skbuff.h structure changes more
   intelligently.  Currently the netfilter stuff is:

	pointer
	u32
	pointer
	u32

   and this wastes a lot of space on 64-bitters.

2) There is no way I'm amicable to exporting __tcp_v4_lookup()
   and friends to modules.

   Are you absolutely sure that the existing scheme cannot
   work properly?  I'm talking about relying upon skb->sk
   being sane.

So what I think I'll do is merge in all the changes other
than the ipt_owner.c change by hand into a tree I'll push
to Linus, I'll also fix the layout ordering problem which
I mentioned above in #1

But something has to be done about the ipt_owner.c change, it
isn't going in as-is.

  reply	other threads:[~2004-09-22  0:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-21  3:20 [PATCH 2.6 0/12]: netfilter update Patrick McHardy
2004-09-21 21:36 ` David S. Miller
2004-09-21 23:38   ` Patrick McHardy
2004-09-22  0:18     ` David S. Miller [this message]
2004-09-22  1:42       ` Patrick McHardy
2004-09-24 22:40         ` David S. Miller
2004-09-26 19:43           ` Patrick McHardy
2004-09-26 21:45             ` Henrik Nordstrom
2004-09-26 21:56               ` Patrick McHardy
2004-09-26 22:08                 ` Henrik Nordstrom
2004-09-26 23:19                   ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040921171857.2c720c8e.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.