From: maximilian attems <janitor@sternwelten.at>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] base/dmapool: replace
Date: Tue, 21 Sep 2004 21:14:38 +0000 [thread overview]
Message-ID: <20040921211438.GD4260@stro.at> (raw)
In-Reply-To: <20040915183200.GH4363@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]
On Wed, 15 Sep 2004, Nishanth Aravamudan wrote:
> Any comments would be appreciated.
>
> Description: msleep_interruptible() is used instead of schedule_timeout()
> to guarantee the task delays as expected. To achieve this, the timeout
> variable is converted from jiffies to msecs. Also, set_current_state()
> is used instead of direct assignment.
>
> --- 2.6.9-rc2-vanilla/drivers/base/dmapool.c 2004-09-13 17:15:46.000000000 -0700
> +++ 2.6.9-rc2/drivers/base/dmapool.c 2004-09-14 11:37:07.000000000 -0700
> @@ -34,7 +34,7 @@ struct dma_page { /* cacheable header fo
> unsigned long bitmap [0];
> };
>
> -#define POOL_TIMEOUT_JIFFIES ((100 /* msec */ * HZ) / 1000)
> +#define POOL_TIMEOUT_MSECS (100) /* msec */
> #define POOL_POISON_FREED 0xa7 /* !inuse */
> #define POOL_POISON_ALLOCATED 0xa9 /* !initted */
>
> @@ -293,11 +293,11 @@ restart:
> if (mem_flags & __GFP_WAIT) {
> DECLARE_WAITQUEUE (wait, current);
>
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state (TASK_INTERRUPTIBLE);
> add_wait_queue (&pool->waitq, &wait);
> spin_unlock_irqrestore (&pool->lock, flags);
>
> - schedule_timeout (POOL_TIMEOUT_JIFFIES);
> + msleep_interruptible(POOL_TIMEOUT_MSECS);
>
> remove_wait_queue (&pool->waitq, &wait);
> goto restart;
added include for kjt.
a++ maks
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-09-21 21:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 18:32 [Kernel-janitors] [PATCH] base/dmapool: replace schedule_timeout() Nishanth Aravamudan
2004-09-21 21:14 ` maximilian attems [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040921211438.GD4260@stro.at \
--to=janitor@sternwelten.at \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.