From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] Re: [PATCH -mm 7/9] pci_find_device to
Date: Tue, 21 Sep 2004 23:48:21 +0000 [thread overview]
Message-ID: <20040921234821.GC16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040921225243.GC16690@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]
On Tue, Sep 21, 2004 at 03:52:43PM -0700, Greg KH wrote:
> > @@ -7338,17 +7339,19 @@ static int __devinit tg3_get_invariants(
> > * every mailbox register write to force the writes to be
> > * posted to the chip in order.
> > */
> > - if (pci_find_device(PCI_VENDOR_ID_INTEL,
> > - PCI_DEVICE_ID_INTEL_82801AA_8, NULL) ||
> > - pci_find_device(PCI_VENDOR_ID_INTEL,
> > - PCI_DEVICE_ID_INTEL_82801AB_8, NULL) ||
> > - pci_find_device(PCI_VENDOR_ID_INTEL,
> > - PCI_DEVICE_ID_INTEL_82801BA_11, NULL) ||
> > - pci_find_device(PCI_VENDOR_ID_INTEL,
> > - PCI_DEVICE_ID_INTEL_82801BA_6, NULL) ||
> > - pci_find_device(PCI_VENDOR_ID_AMD,
> > - PCI_DEVICE_ID_AMD_FE_GATE_700C, NULL))
> > + if ((pdev = pci_get_device(PCI_VENDOR_ID_INTEL,
> > + PCI_DEVICE_ID_INTEL_82801AA_8, NULL)) ||
> > + (pdev = pci_get_device(PCI_VENDOR_ID_INTEL,
> > + PCI_DEVICE_ID_INTEL_82801AB_8, NULL)) ||
> > + (pdev = pci_get_device(PCI_VENDOR_ID_INTEL,
> > + PCI_DEVICE_ID_INTEL_82801BA_11, NULL)) ||
> > + (pdev = pci_get_device(PCI_VENDOR_ID_INTEL,
> > + PCI_DEVICE_ID_INTEL_82801BA_6, NULL)) ||
> > + (pdev = pci_get_device(PCI_VENDOR_ID_AMD,
> > + PCI_DEVICE_ID_AMD_FE_GATE_700C, NULL))) {
> > tp->tg3_flags |= TG3_FLAG_MBOX_WRITE_REORDER;
> > + pci_dev_put(pdev);
> > + }
>
> If you have more than one device that matches these different tests, you
> will have grabbed a reference and lost it, without freeing it.
The || short-circuits. As soon as one of these returns a non-null pdev,
the others won't be called.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-09-21 23:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-21 22:52 [Kernel-janitors] Re: [PATCH -mm 7/9] pci_find_device to Greg KH
2004-09-21 23:48 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040921234821.GC16153@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.