All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Prasanna S Panchamukhi <prasanna@in.ibm.com>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
	Andrew Morton <akpm@osdl.org>,
	suparna@in.ibm.com, Tom Rini <trini@kernel.crashing.org>,
	kgdb-bugreport@lists.sourceforge.net
Subject: Re: [Patch] kprobes exception notifier fix 2.6.9-rc2
Date: 23 Sep 2004 10:06:28 +0200
Date: Thu, 23 Sep 2004 10:06:28 +0200	[thread overview]
Message-ID: <20040923080627.GA89752@muc.de> (raw)
In-Reply-To: <20040923053029.GB1291@in.ibm.com>

On Thu, Sep 23, 2004 at 11:00:29AM +0530, Prasanna S Panchamukhi wrote:
> In order to make other debuggers use exception notifiers, kprobes 
> notifier return values are required to be modified. This patch modifies the
> return values of kprobes notifier return values in a clean way.

It's incompatible to x86-64. If you change anything in exception
notifiers change both.

And I don't really see the sense of inverting the test: NOTIFY_OK
for handling the exception should be as good as NOTIFY_STOP.

-Andi

  reply	other threads:[~2004-09-23  8:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-23  5:30 [Patch] kprobes exception notifier fix 2.6.9-rc2 Prasanna S Panchamukhi
2004-09-23  8:06 ` Andi Kleen [this message]
2004-09-23  8:45   ` Prasanna S Panchamukhi
2004-09-23 19:32   ` David S. Miller
2004-09-27 12:10     ` Prasanna S Panchamukhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040923080627.GA89752@muc.de \
    --to=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prasanna@in.ibm.com \
    --cc=suparna@in.ibm.com \
    --cc=torvalds@osdl.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.