From: William Lee Irwin III <wli@holomorphy.com>
To: Kirill Korotaev <dev@sw.ru>
Cc: Albert Cahalan <albert@users.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [Q] possible proc inode numbers overflow?
Date: Fri, 24 Sep 2004 07:04:08 -0700 [thread overview]
Message-ID: <20040924140408.GF9106@holomorphy.com> (raw)
In-Reply-To: <41542ADF.5070202@sw.ru>
On Fri, Sep 24, 2004 at 06:10:39PM +0400, Kirill Korotaev wrote:
> fs/proc/generic.c:
> #define PROC_DYNAMIC_FIRST 0xF0000000UL
> static unsigned int get_inode_number(void)
> {
> ...
> inum = (i & MAX_ID_MASK) + PROC_DYNAMIC_FIRST;
>
> /* inum will never be more than 0xf0ffffff, so no check
> * for overflow.
> */
> ...
> }
> is it really correct? Looks like MAX_ID_MASK = 0x7FFFFFFF and
> PROC_DYNAMIC_FIRST is 0xF0000000.
> So at least the comment is wrong?
The comment is wrong. Albert Cahalan and I are working on a new fix.
-- wli
prev parent reply other threads:[~2004-09-24 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-24 14:10 [Q] possible proc inode numbers overflow? Kirill Korotaev
2004-09-24 14:04 ` William Lee Irwin III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040924140408.GF9106@holomorphy.com \
--to=wli@holomorphy.com \
--cc=albert@users.sourceforge.net \
--cc=dev@sw.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.